Closed Bug 1268178 Opened 3 years ago Closed 3 years ago

Intermittent browser_addons_debug_bootstrapped.js | This test exceeded the timeout threshold. It should be rewritten or split up.

Categories

(DevTools :: about:debugging, defect, P2)

Product:
DevTools
Component:
about:debugging
Version:
49 Branch
Type:
defect

Tracking

(firefox49 fixed, firefox50 fixed)

Status:
RESOLVED FIXED
Milestone:
Firefox 50
Tracking Flags:
Tracking Status
firefox49 --- fixed
firefox50 --- fixed

People

(Reporter: KWierso, Assigned: jdescottes)

References

Details

(Keywords: intermittent-failure)

Attachments

(1 file)

Bug 1268178 - fix browser_addons_debug_bootstrapped.js intermittent;
58 bytes, text/x-review-board-request
ochameau
: review+
Details
Priority: -- → P3
Priority: P3 → P2
See Also: → 1278111
Assignee: nobody → jdescottes
Status: NEW → ASSIGNED
Julian, this intermittent may just be needing a requestLongerTimeout() call.

It seems to fail during test shutdown and may just be long to finish:

 23:46:47     INFO -  17 INFO TEST-PASS | devtools/client/aboutdebugging/test/browser_addons_debug_bootstrapped.js | After uninstall, the addon name disappears from the list of addons: Firefox Hello,FlyWeb,IndexedDBTest,Mochitest,mozscreenshots,Multi-process staged rollout,Pocket,Special Powers,Web Compat,WorkerTestBootstrap -
 23:46:47     INFO -  18 INFO Closing about:debugging
 23:46:47     INFO -  19 INFO Removing tab.
 23:46:47     INFO -  20 INFO Waiting for event: 'TabClose' on [object XULElement].
 23:46:47     INFO -  21 INFO Got event: 'TabClose' on [object XULElement].
 23:46:47     INFO -  22 INFO Tab removed and finished closing
 23:46:47     INFO -  23 INFO Leaving test bound
 23:46:47     INFO -  24 INFO TEST-UNEXPECTED-FAIL | devtools/client/aboutdebugging/test/browser_addons_debug_bootstrapped.js | This test exceeded the timeout threshold. It should be rewritten or split up. If that's not possible, use requestLongerTimeout(N), but only as a last resort.
(In reply to Alexandre Poirot [:ochameau] from comment #12)
> Julian, this intermittent may just be needing a requestLongerTimeout() call.
> 
> It seems to fail during test shutdown and may just be long to finish:
> 
>  23:46:47     INFO -  17 INFO TEST-PASS |
> devtools/client/aboutdebugging/test/browser_addons_debug_bootstrapped.js |
> After uninstall, the addon name disappears from the list of addons: Firefox
> Hello,FlyWeb,IndexedDBTest,Mochitest,mozscreenshots,Multi-process staged
> rollout,Pocket,Special Powers,Web Compat,WorkerTestBootstrap -
>  23:46:47     INFO -  18 INFO Closing about:debugging
>  23:46:47     INFO -  19 INFO Removing tab.
>  23:46:47     INFO -  20 INFO Waiting for event: 'TabClose' on [object
> XULElement].
>  23:46:47     INFO -  21 INFO Got event: 'TabClose' on [object XULElement].
>  23:46:47     INFO -  22 INFO Tab removed and finished closing
>  23:46:47     INFO -  23 INFO Leaving test bound
>  23:46:47     INFO -  24 INFO TEST-UNEXPECTED-FAIL |
> devtools/client/aboutdebugging/test/browser_addons_debug_bootstrapped.js |
> This test exceeded the timeout threshold. It should be rewritten or split
> up. If that's not possible, use requestLongerTimeout(N), but only as a last
> resort.

That was my guess as well but I wanted to get some metrics before just adding a longer timeout.

I added timings to a try run here: https://treeherder.mozilla.org/#/jobs?repo=try&revision=e3459fced2c2&selectedJob=23564307
Turns out, it takes almost 30 seconds to perform "yield onCustomMessage;" after clicking on the debug button. Looks like we wait on "a notification sent by a script evaluated the test addon via the web console".

I don't think there's much we can do here to speed up this process, so I think it is ok to simply wait longer.
Comment on attachment 8770505 [details]
Bug 1268178 - fix browser_addons_debug_bootstrapped.js intermittent;

https://reviewboard.mozilla.org/r/63916/#review60982

I imagine there is most likely many ways to optimise runtime speed of browser toolbox opening, but that sounds like a significant work.
Recently I fixed "debugger would run" exception which significantly slow down things, there may be some left?

But in the meantime, better make this test non-intermittent.
Attachment #8770505 - Flags: review?(poirot.alex) → review+
Pushed by jdescottes@mozilla.com:
https://hg.mozilla.org/integration/fx-team/rev/b8b27cb2e148
fix browser_addons_debug_bootstrapped.js intermittent;r=ochameau
https://hg.mozilla.org/mozilla-central/rev/b8b27cb2e148
Status: ASSIGNED → RESOLVED
Closed: 3 years ago
status-firefox50: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 50
Duplicate of this bug: 1278111
Product: Firefox → DevTools
You need to log in before you can comment on or make changes to this bug.