1268205 - Normalize clang function qualnames to prevent missing results for 'callers:' queries

Status: RESOLVED FIXED

(Webtools Graveyard :: DXR, defect)

Description

[Tom Klein]

We have several open bugs of at least two types for which a 'callers:' query is missing some expected results.

Type 1: the query misses results because some function refs for the function in question write certain qualname parameters as 'class mytype' (or 'enum myenum' or 'struct mystruct' etc.) while others write simply 'mytype'.  See bug 1223671 for example.

Type 2: some function ref qualnames include a namespace specifier (as in 'Maybe<gfx::IntSize>'), others skip the namespace (just 'Maybe<IntSize>').
See bug 1266577 for example.

In both cases the issue is that in our clang plugin, we ask for function parameters (using 'getQualifiedName') at each function ref we see, but as it turns out clang doesn't always return the same string for each parameter at each ref, at least not the way we're currently asking for them.

Comment 1

[Tom Klein]

Fix up for review at https://github.com/mozilla/dxr/pull/530

Comment 2

[Tom Klein]

Fixed by https://github.com/mozilla/dxr/pull/530