1268263 - URLs from firefox:// scheme are double unescaped

Status: RESOLVED FIXED

(Firefox for iOS :: General, defect)

Description

[James Hugman [:jhugman] [@jhugman]]

This came out of https://bugzilla.mozilla.org/show_bug.cgi?id=1266091

We try to open a google search for "cheese platter". This is correctly encoded as:

  firefox://open-url?url=https%3A%2F%2Fwww.google.com%2Fsearch%3Fq%3Dcheese%2520platter

by the open-in demo project.

We receive this in application(application:, openURL:, sourceApplication:, annotation:):

   firefox://open-url?url=https%3A%2F%2Fwww.google.com%2Fsearch%3Fq%3Dcheese%2520platter

Which we parse with NSURLComponents and take the url parameter we have:

   https://www.google.com/search?q=cheese%20platter

Then we double decode it with url.unescape, which results in the following invalid and ignored URL:

  https://www.google.com/search?q=cheese platter

The fix here is to not url.unescape() - NSURLComponents has already done that.

Comment 1

[Stefan Arentz | :st3fan | ⏰ EST | he/him]

I'm marking this as blocking 4.0 because this is a one line and low risk fix.

Comment 2

[James Hugman [:jhugman] [@jhugman]]

Attachment: Pull request

One line fix.

I wanted to fix the url method argument being redeclared as String? but wanted to keep this minimal.

https://github.com/mozilla/firefox-ios/commit/c58b52970b15434a2e1c567bf1dcfcb7e83c68e6#diff-19fd1a6fe4b2f78eb457726f366733e0

Comment 3

[James Hugman [:jhugman] [@jhugman]]

Merged and closed.