Closed Bug 1268317 Opened 4 years ago Closed 3 years ago

Add Triage Contact to Components as an Editable Field

Categories

(bugzilla.mozilla.org :: General, defect, P2)

Production
defect

Tracking

()

RESOLVED FIXED

People

(Reporter: emceeaich, Assigned: dkl)

References

Details

User Story

As a bugzilla user with edit component/product privileges, I should be able to set a triage contact for a component, so that users can easily find who is responsible for triaging bugs in the component, reports can be generated, and nagging can be done.

Attachments

(2 files, 2 obsolete files)

Add triage contact, a valid bugzilla user email/id, to the component configuration form. In addition, one should be able to get a report of the triage contacts for components, and that the triage contact can be used to nag them.
Priority: -- → P2
This would also be useful for sheriffs, as we could use the triage contact as a person we could Cc/Needinfo when an intermittent failure becomes too frequent to ignore.
The triage responsible person should appear in the people block of the modal bug view. The responsible person should also be exposed as a field in bug lists, be searchable (since in many cases, one person will triage many components.)
Assignee: nobody → dkl
Status: NEW → ASSIGNED
Mike could you pass along the map of mozilla to bugzilla emails so we can populate with the right emails?
Flags: needinfo?(mhoye)
The one I have is pretty outdated; I'll need to regenerate it. Leaving needinfo in place for the moment.
Attached patch 1268317_1.patch (obsolete) β€” β€” Splinter Review
Attachment #8787774 - Flags: review?(dylan)
Comment on attachment 8787774 [details] [diff] [review]
1268317_1.patch

Review of attachment 8787774 [details] [diff] [review]:
-----------------------------------------------------------------

r-

I think we need to support the %user% pronoun in the triage owner search field. 
IIRC this involves the hash SPECIAL_PARSING.

also a small typo had to be fixed to make this work. :-)

::: Bugzilla/DB/Schema.pm
@@ +1454,2 @@
>                                   DEFAULT => 'TRUE'},
> +            triage_onwer_id  => {TYPE => 'INT3',

typo :-)
Attachment #8787774 - Flags: review?(dylan) → review-
(In reply to Emma Humphries β˜•οΈ [:emceeaich] (UTC-8) +needinfo me from comment #4)
> Mike could you pass along the map of mozilla to bugzilla emails so we can
> populate with the right emails?

I think I have this one now. I need to map to components, but then we'll be much of the way to a list to populate the field with.
Flags: needinfo?(mhoye)
Attached file Triage Leads - Bugmail to Component.csv (obsolete) β€”
In order to populate that field, here's the list of components and triagers in CSV.

In that list, the 'Bugmail' column is the field to enter for each component.
(In reply to Emma Humphries β˜•οΈ [:emceeaich] (UTC-8) +needinfo me from comment #9)
> Created attachment 8791007 [details]
> Triage Leads - Bugmail to Component.csv
> 
> In order to populate that field, here's the list of components and triagers
> in CSV.
> 
> In that list, the 'Bugmail' column is the field to enter for each component.

I have noticed a number of errors for the "Bugmail" column of the DevTools components:

Developer Tools: Memory: bugmail for fitzgen@mozilla.com should be nfitzgerald@mozilla.com
Developer Tools: Scratchpad: bugmail for fitzgen@mozilla.com should be nfitzgerald@mozilla.com
Developer Tools: JSON Viewer: original email does not match person on wiki (should say odvarko@gmail.com), bugmail should be odvarko@gmail.com
Developer Tools: Netmonitor: original email does not match person on wiki (should say odvarko@gmail.com), bugmail should be odvarko@gmail.com

These issues suggest to me that this data set does not reflect edits to the triage leads wiki after its original bulk creation (since I know that JSON Viewer and Netmonitor were edited on the wiki after the fact to correct the triage lead to the right person).
Flags: needinfo?(ehumphries)
(In reply to J. Ryan Stinnett [:jryans] (use ni?) (on PTO Sept. 10 - 25) from comment #10)
> (In reply to Emma Humphries β˜•οΈ [:emceeaich] (UTC-8) +needinfo me from
> comment #9)
> 
> I have noticed a number of errors for the "Bugmail" column of the DevTools
> components:

You are right and I'll correct that. The updated wiki was not copied to the google doc I was using. I'll extract the wiki and recreate that list. 

This is one of the reasons I'm getting this moved into Bugzilla; so that no one is juggling wikis and spreadsheets that get out of sync with one another.
I don't have a map, sadly, all I've got is a flat list of "was a mozilla employee at some point" bugmail addresses.
Attached patch 1268317_2.patch β€” β€” Splinter Review
Attachment #8787774 - Attachment is obsolete: true
Attachment #8791342 - Flags: review?(dylan)
Updated list of triage leads from wiki with mapping from common email to LDAP and bugmail (as found in phonebook) fixes errors jryans found.
Attachment #8791007 - Attachment is obsolete: true
Flags: needinfo?(ehumphries)
Comment on attachment 8791342 [details] [diff] [review]
1268317_2.patch

Review of attachment 8791342 [details] [diff] [review]:
-----------------------------------------------------------------

r=dylan
Attachment #8791342 - Flags: review?(dylan) → review+
(In reply to Emma Humphries β˜•οΈ [:emceeaich] (UTC-8) +needinfo me from comment #14)
> Created attachment 8791813 [details]
> Triage Leads With Queries - Bugmail to Component.csv
> 
> Updated list of triage leads from wiki with mapping from common email to
> LDAP and bugmail (as found in phonebook) fixes errors jryans found.

Emma, can you file this a separate bug (dependent of this one) from this one related to populating the new triage owners? we can create a script to do that.

Thanks
dkl
(In reply to David Lawrence [:dkl] from comment #16)

> Emma, can you file this a separate bug (dependent of this one) from this one
> related to populating the new triage owners? we can create a script to do
> that.

Done.
(In reply to Dylan Hardison [:dylan] from comment #15)
> Comment on attachment 8791342 [details] [diff] [review]
> 1268317_2.patch
> 
> Review of attachment 8791342 [details] [diff] [review]:
> -----------------------------------------------------------------
> 
> r=dylan

Will need to do this a two part push since it makes schema changes.

To https://github.com/mozilla-bteam/bmo.git
   f895dcd..0ebea6d  master -> master

Schema part checked in.

dkl
And everything else.

To https://github.com/mozilla-bteam/bmo.git
   0ebea6d..8affa3e  master -> master

dkl
Status: ASSIGNED → RESOLVED
Closed: 3 years ago
Resolution: --- → FIXED
This is live now. Just need to populate the new component values.

dkl
You need to log in before you can comment on or make changes to this bug.