126834 - CERTSignedCrl * SEC_NewCrl(....) fails to set the 'url' field in the return struct

Status: RESOLVED FIXED

(NSS :: Libraries, defect, P1)

Description

[Rangan Sen]

Note that the value for the url passed is actually stored correctly in the db -
but it is somehow not set correctly in the ret val.

Comment 1

[Wan-Teh Chang]

I checked the NSS 3.3.2 source code and found that it doesn't
set the url field of the return value of SEC_NewCrl either.
So my first finding is that this is not a regression of NSS
3.4.

It's not clear to me whether SEC_NewCrl is supposed to set
the url field of the return value.  Bob, do you know?  Rangan,
do you need SEC_NewCrl to set the url field of its return value?

I did find a problem in SEC_FindCrlByKeyOnSlot that should be
unrelated to Rangan's complaint.  SEC_FindCrlByKeyOnSlot is not
setting the url field of its return value either.  SEC_NewCrl
calls SEC_FindCrlByKeyOnSlot and checks the url field of the
return value, so this is problematic.

Comment 2

[Wan-Teh Chang]

Sorry, my previous comment was wrong.  SEC_NewCrl in NSS 3.3.2
sets the 'url' field in the return value.  So this bug is a
regression of NSS 3.4.

Comment 3

[Rangan Sen]

Wan-Teh: We need the url value to enable automatic update for the crl...

Comment 4

[Robert Relyea]

Attachment: Fix missing URL values from crl structure.

This patch actually fixes both bug 126834 (this one) and bug 127254 . Note the
change in the PK11_FindCRLByName. It should be safe because this function is
not exported.

Comment 5

[Wan-Teh Chang]

Rangan, could you check out the tip of NSS and see if Bob's
patch fixed your problem?  Thanks.

Comment 6

[Wan-Teh Chang]

Comment on attachment 71410 [details] [diff] [review]
Fix missing URL values from crl structure.

r=wtc.

Comment 7

[Rangan Sen]

Works ok now, with the tip of NSS...however, we won't see the effect of the fix 
in the nightly builds unless the NSS_CLIENT_TAG is moved...

Comment 8

[Wan-Teh Chang]

Rangan,

The Mozilla tree is closed for mozilla 0.9.9 right now, so
I can't move the NSS_CLIENT_TAG without an approval from
[e-mail].

If you want this fix in mozilla 0.9.9, we need to get an
approval from the drivers.

Comment 9

[Rangan Sen]

I think we should try to get an approval for this, because without this the crl 
autoupdate feature would be rather unusable ... 
Stephane: what's your openion on this?
Also, we probably should try to get an approval for bug# 108021, as well...

Comment 10

[Robert Relyea]

wtc's review is sufficient for this to make NSS 3.4.

bob

Comment 11

[Wan-Teh Chang]

The fix is in the NSS_CLIENT_TAG of NSS now.
Marked the bug fixed.