1268341 - Suppress gdk deprecated warning

Status: RESOLVED FIXED

(Core :: DOM: Core & HTML, defect)

Description

[Kyle Huey (Exited; not receiving bugmail, old account, do not use)]

Attachment: Patch

This annoys me when rebuilding dom/

Comment 1

[Olli Pettay [:smaug][[e-mail]]]

Comment on attachment 8746361 [details] [diff] [review]
Patch

Fine to me, but could we actually use some non-deprecated function here?

Comment 2

[Karl Tomlinson (:karlt)]

Comment on attachment 8746361 [details] [diff] [review]
Patch

(In reply to Olli Pettay [:smaug] from comment #1)
> Fine to me, but could we actually use some non-deprecated function here?

While the GTK2 port is alive, and RedHat will maintain this for some time, I expect, these warnings are not helpful, because we'd need two code paths more often.

Even for GTK3 only, this is non-trivial as the newer gdk_device_ungrab needs the device from the button press event, or maybe this could be restricted to the core pointer.  There an open bug on these somewhere.

If these are spread too far and wide, then GDK_DISABLE_DEPRECATION_WARNINGS could be set in TK_FLAGS, extending the approach of
https://bugzilla.mozilla.org/show_bug.cgi?id=1257695

Comment 3

[Pulsebot]

https://hg.mozilla.org/integration/mozilla-inbound/rev/2b2f43e1bf59

Comment 4

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/2b2f43e1bf59