1268347 - Wrapping occurs inside "text-combine-upright:all" element.

Status: RESOLVED FIXED

(Core :: Layout: Text and Fonts, defect)

Description

[baba]

Attachment: line-break.html

User Agent: Mozilla/5.0 (Windows NT 6.3; Win64; x64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/50.0.2661.87 Safari/537.36

Steps to reproduce:

Open attached HTML.


Actual results:

Wrapping occurs between "H" and "I". They are shaped upright.


Expected results:

"H" and "I" should be combined. Line wrapping shouldn't occur between them.

Comment 1

[baba]

Attachment: result.png

Comment 2

[Jonathan Kew [:jfkthame]]

Ah, there's an actual space in there. I guess we didn't consider that. Explicitly applying white-space:nowrap to the element fixes the result; but that shouldn't be necessary.

Comment 3

[Xidorn Quan [:xidorn] UTC+10]

Hmmm, an optional break position is recorded at the space.

Okay, thanks for reporting. I've had the fix, but I need to work out a reftest as well, so will submit a patch tomorrow.

Comment 4

[Xidorn Quan [:xidorn] UTC+10]

Attachment: MozReview Request: Bug 1268347 - Forbid break opportunities inside horizontal-in-vertical. r?jfkthame

Review commit: https://reviewboard.mozilla.org/r/50127/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/50127/

Comment 5

[Jonathan Kew [:jfkthame]]

Comment on attachment 8748057 [details]
MozReview Request: Bug 1268347 - Forbid break opportunities inside horizontal-in-vertical. r?jfkthame

https://reviewboard.mozilla.org/r/50127/#review46975

Comment 6

[Pulsebot]

https://hg.mozilla.org/integration/mozilla-inbound/rev/9a5bd81a3105

Comment 7

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/9a5bd81a3105