Closed Bug 1268378 Opened 9 years ago Closed 9 years ago

Fire TypeError from IDBDatabase.transaction() if Mode is Invalid.

Categories

(Core :: Storage: IndexedDB, defect)

defect
Not set
normal

Tracking

()

RESOLVED FIXED
mozilla49
Tracking Status
firefox49 --- fixed

People

(Reporter: bevis, Assigned: bevis)

Details

(Whiteboard: [tw-dom] btpp-active)

Attachments

(1 file)

In IDB Spec v2 [1], TypeError is expected if |mode| parameter is incorrect. However, ​InvalidAccessError is return instead in Gecko [2]. [1] http://w3c.github.io/IndexedDB/#dom-idbdatabase-transaction. [2] https://hg.mozilla.org/mozilla-central/annotate/fc15477ce628599519cb0055f52cc195d640dc94/dom/indexedDB/IDBDatabase.cpp#l684
Whiteboard: [tw-dom] → [tw-dom] btpp-active
1. Quick fix to return correct error cause. 2. Add Test coverage for this change.
Attachment #8746909 - Flags: review?(khuey)
Status: NEW → ASSIGNED
Attachment #8746909 - Attachment description: (v1) Patch: Fire TypeError from IDBDatabase.transaction() if Mode is Invalid. → (v1) Patch: Fire TypeError from IDBDatabase.transaction() if Mode is Invalid. r=khuey
treeherder result looks fine in comment 1.
Keywords: checkin-needed
Status: ASSIGNED → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla49
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: