1268387 - [Static Analysis][Resource leak] In function nsHttpChannel::ForceCacheEntryValidFor

Status: RESOLVED FIXED

(Core :: Networking, defect)

Description

[Andi [:andi]]

The Static Analysis tool Coverity added that ToNewCString(key) leaks memory in: 

    } else {
        mCacheEntry->ForceValidFor(aSecondsToTheFuture);

        nsAutoCString key;
        mCacheEntry->GetKey(key);

        LOG(("nsHttpChannel::ForceCacheEntryValidFor successfully forced valid "
             "entry with key %s for %d seconds. [this=%p]", ToNewCString(key),
             aSecondsToTheFuture, this));
    }

This should be fixed by freeing the memory allocated by ToNewCString(key).

Comment 1

[Andi [:andi]]

Attachment: MozReview Request: Bug 1268387 - avoid memory leak of ToNewCString(key). r?valentin

Review commit: https://reviewboard.mozilla.org/r/49423/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/49423/

Comment 2

[Valentin Gosu [:valentin] (he/him)]

(In reply to Andi-Bogdan Postelnicu from comment #0) 
> This should be fixed by freeing the memory allocated by ToNewCString(key).

Can't we just use key.get() instead of allocating?

Comment 3

[Andi [:andi]]

Comment on attachment 8746424 [details]
MozReview Request: Bug 1268387 - avoid memory leak of ToNewCString(key). r?valentin

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/49423/diff/1-2/

Comment 4

[Andi [:andi]]

(In reply to Valentin Gosu [:valentin] from comment #2)
> (In reply to Andi-Bogdan Postelnicu from comment #0) 
> > This should be fixed by freeing the memory allocated by ToNewCString(key).
> 
> Can't we just use key.get() instead of allocating?

sure why not, just updated the patch.

Comment 5

[Andi [:andi]]

Comment on attachment 8746424 [details]
MozReview Request: Bug 1268387 - avoid memory leak of ToNewCString(key). r?valentin

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/49423/diff/2-3/

Comment 6

[Valentin Gosu [:valentin] (he/him)]

Comment on attachment 8746424 [details]
MozReview Request: Bug 1268387 - avoid memory leak of ToNewCString(key). r?valentin

https://reviewboard.mozilla.org/r/49423/#review46273

Thanks!

Comment 7

[Pulsebot]

https://hg.mozilla.org/integration/mozilla-inbound/rev/a29de45d453b

Comment 8

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/a29de45d453b