1268423 - [TV][Home] Sort cards by alphabet order in the filtering mode

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia::TV::Home, defect)

Description

[Luke Chang [:lchang] (inactive)]

According to Item 6 in Spec v2.1, after filtering, we should show the filtering deck first and then show cards in that category by alphabet.

Comment 1

[GitHub Autolander Bot]

Attachment: [gaia] Fischer-L:bug_1268423-sort-cards-in-filter-mode > mozilla-b2g:v2.6

Comment 2

[Fischer [:Fischer]]

Comment on attachment 8749556 [details] [review]
[gaia] Fischer-L:bug_1268423-sort-cards-in-filter-mode > mozilla-b2g:v2.6

@Luke,

This patch would do in the filtering mode:

- Hide cards which has the same name and is launched to the same url
- Sort cards based on names (by reusing the getSortKey method)

Thanks

Comment 3

[Luke Chang [:lchang] (inactive)]

Comment on attachment 8749556 [details] [review]
[gaia] Fischer-L:bug_1268423-sort-cards-in-filter-mode > mozilla-b2g:v2.6

Generally looks good except a few nits. Let's improve it.

Comment 4

[Fischer [:Fischer]]

Comment on attachment 8749556 [details] [review]
[gaia] Fischer-L:bug_1268423-sort-cards-in-filter-mode > mozilla-b2g:v2.6

@Luke,
Thanks for suggestions. Updated, please have a look.

Comment 5

[Luke Chang [:lchang] (inactive)]

Comment on attachment 8749556 [details] [review]
[gaia] Fischer-L:bug_1268423-sort-cards-in-filter-mode > mozilla-b2g:v2.6

Nice work! Thanks.

Comment 6

[Fischer [:Fischer]]

Land to v2.6: https://github.com/mozilla-b2g/gaia/commit/b21ef5fd763ae33c3a0d6f753f39c755b2c6bb88