Closed Bug 1268424 Opened 5 years ago Closed 4 years ago

Collect Telemetry data about the search plugin count

Categories

(Firefox :: Search, defect, P3)

defect

Tracking

()

RESOLVED FIXED
Firefox 49
Tracking Status
firefox49 --- fixed

People

(Reporter: florian, Assigned: florian)

References

Details

(Whiteboard: [fxsearch])

Attachments

(1 file, 1 obsolete file)

We don't have any probe collecting information about how many search plugins are installed in user profiles. I've always assumed that installing search plugins is something a minority of power users do, but it would be interesting to know how many people do it, and what's a typical number of search plugins.
Marty, this is about collecting statistics about search plugin count, not about finding specific users who do use lots of them.
The patch is trivial to the point that I don't think adding test coverage for it is useful, but I can totally write a test for this value if you disagree.
Attachment #8748708 - Flags: review?(benjamin)
Attachment #8748708 - Flags: review?(adw)
Assignee: nobody → florian
Status: NEW → ASSIGNED
Comment on attachment 8748708 [details] [diff] [review]
Collect Telemetry data about the search plugin count,

We should absolutely measure this. I don't think this should be permanent though, because we don't have a clear long-term monitoring plan or user value. Instead, make this expires_in_version: "55" to see what the data looks like and then decide whether it has long-term value.

Also, this should be releaseChannelCollection: opt-out. You really care about this with the release population and there's a clear short-term user value in understading the prevalence of extra installed providers.

The description should be more specific like the one below: when this is recorded (near startup? or is it re-recorded when somebody adds a new search engine). Does this include both builtin and external search engines? Perhaps it's more valuable to record only the count of user-installed engines?

With those changes, data-review=me

If this were going to be permanent, I do think you should have a unit test for it: it's the kind of thing that's easy to break by accident.
Attachment #8748708 - Flags: review?(benjamin) → feedback+
(In reply to Benjamin Smedberg  [:bsmedberg] from comment #6)

> The description should be more specific like the one below: when this is
> recorded (near startup? or is it re-recorded when somebody adds a new search
> engine).

It's recorded when the search service initialization finishes. When a new search engine is added, we won't record again before the next browser restart.

> Does this include both builtin and external search engines?

Yes.

> Perhaps
> it's more valuable to record only the count of user-installed engines?

There are a few different things that could be interesting to record:
- the count of user-installed engines
- the count of built-in engines that have been hidden
- the count of engines actually visible as one-off buttons (this is configurable from the search preferences).

Recording the total count of engines accessible to the search service seems like a good first step to me.
Attachment #8748708 - Flags: review?(adw) → review+
Attached patch Patch v2Splinter Review
Attachment #8748708 - Attachment is obsolete: true
https://hg.mozilla.org/integration/fx-team/rev/98fc8be146c7b95bf48d19d0476797bf272e7700
Bug 1268424 - Collect Telemetry data about the search plugin count, data-review=bsmedberg, r=adw.
https://hg.mozilla.org/mozilla-central/rev/98fc8be146c7
Status: ASSIGNED → RESOLVED
Closed: 4 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 49
Depends on: 1345080
IHAQ: Where can I find the results of the telemetry collection?

If I understand correctly then the new search engine telemetry collection was introduced in version: milestone	49.0a1 und should be operational by now.
(In reply to marty from comment #11)
> IHAQ: Where can I find the results of the telemetry collection?

https://mzl.la/2t9KUOm
You need to log in before you can comment on or make changes to this bug.