1268433 - Update ReadTheDocs links

Status: NEW

(Firefox :: General, defect)

Description

[Rémy Hubscher (:natim)]

Attachment: Link to Github PR — #105.

Readthedocs for documentation changed from readthedocs.org to readthedocs.io

Here is an attempt to

Comment 1

[:Gijs (he/him)]

(In reply to Rémy Hubscher (:natim) from comment #0)
> Here is an attempt to

? :-)

Did you intend to attach a patch? Please see the docs for mozreview and git: http://mozilla-version-control-tools.readthedocs.org/en/latest/mozreview/install-git.html .

Comment 2

[Rémy Hubscher (:natim)]

Here is an attempt to update related links in gecko-dev.

Yes I did a PR but before going further I wanted to know if this kind of patch are of interest.
But I would be glad to make a patch according to the documentation in that case.

Comment 3

[:Gijs (he/him)]

(In reply to Rémy Hubscher (:natim) from comment #2)
> Here is an attempt to update related links in gecko-dev.
> 
> Yes I did a PR but before going further I wanted to know if this kind of
> patch are of interest.

I think probably, but I don't actually know all the code in question. I expect you'll need reviews from the owners of the different bits. Some of the changes look unnecessary and potentially will break tests (specifically the changes in mobile's junit stuff). It seems jgraham owns at least some of the stuff in question, maybe he can help.

Comment 4

[James Graham [:jgraham]]

I think this is a good idea in general, but you need to be more selective with which links you update e.g. avoiding subdirectories corresponding to upstream code that we have imported. As Gijs says, you might have better luck splitting this into several different PRs for different areas of code (at least one per top-level directory, ideally more).

Comment 5

[Rémy Hubscher (:natim)]

Thank you for your feedbacks it helps me to have a better picture of the course of action to take.

Comment 6

[Rémy Hubscher (:natim)]

Do you think I should create a bug per patch or that I can put the different patches in this issue?

Comment 7

[James Graham [:jgraham]]

Multiple patches in a single bug is fine.