1268511 - Akismet payload error with some revision tag strings

Status: VERIFIED FIXED

(developer.mozilla.org Graveyard :: Editing, defect)

Description

[John Whitlock [:jwhitlock]]

What did you do?
================
A user attempted to translate https://developer.mozilla.org/en-US/docs/Web/API/WebSockets_API/Writing_WebSocket_servers

What happened?
==============
An assertion error, because the tags string of the base English revision did not start with a double quote:

Guide, HTML5, NeedsContent, NeedsExample, Tutorial, WebSocket, WebSockets, guide

It was expecting something like:

"Guide", "HTML5", ...

What should have happened?
==========================
The tag string should have been split on commas instead

Is there anything else we should know?
======================================
Sentry reports 2 users have encountered the error: 

https://sentry.prod.mozaws.net/operations/mdn-prod/issues/327956/.  

Will attach traceback.

Comment 1

[John Whitlock [:jwhitlock]]

Attachment: traceback.txt

Traceback of error

Comment 4

[John Whitlock [:jwhitlock]]

This is happening frequently enough that I think it is safe to call it critical before the bug triage meeting.

Comment 5

[Sebastian Zartner [:sebo]]

(In reply to John Whitlock [:jwhitlock] from comment #0)
> ==============
> An assertion error, because the tags string of the base English revision did
> not start with a double quote:
> 
> Guide, HTML5, NeedsContent, NeedsExample, Tutorial, WebSocket, WebSockets,
> guide
> 
> It was expecting something like:
> 
> "Guide", "HTML5", ...

I'm confused by this. Editors never had to enter tags with double quotes. So, what am I supposed to do in this case?

Sebastian

Comment 6

[John Whitlock [:jwhitlock]]

Some revisions have the tags saved with quotes, others do not. This is probably due to some change made in the past in how tags are remembered from revision to revision, so it is a bug more likely to appear when editing a page that hasn't been edited in a while.

There's nothing that can or should be done in the editing interface to work around this bug. It requires a server-side fix.

Comment 7

[Sebastian Zartner [:sebo]]

Thanks for the fast reply! So I'm eager to see this bug fixed then.

Sebastian

Comment 8

[MDN Team (:mdn-dev)]

Commits pushed to master at https://github.com/mozilla/kuma

https://github.com/mozilla/kuma/commit/e71e8129a9fdebc7bcfb95f702c73d84553b9b9d
bug 1268511 - Handle tag lists without quotes

Use taggit.utils.parse_tags to parse revision.tags into a tag list.

https://github.com/mozilla/kuma/commit/a68286665b06cb2ee616f9866362db19ed59d674
Merge pull request #3851 from mozilla/akismet_tags_1268511

bug 1268511 and bug 1259870 - Akismet integration fixes

Comment 9

[John Whitlock [:jwhitlock]]

Fix is in production. Sebastian, can you confirm that you can make your desired edit?

Comment 10

[Sebastian Zartner [:sebo]]

Worked. Thank you for the fast patch!

Sebastian

Comment 11

[Chris Mills [:cmills]]

To confim, my revision at https://developer.mozilla.org/en-US/docs/Glossary/Vendor_Prefix worked as well. Cheers!