1268572 - tracking bug for download button style consistency and associated link updates

Status: RESOLVED FIXED

(www.mozilla.org :: Pages & Content, defect)

Description

[Jennifer Bertsch [:jbertsch]]

Hi All-

This is our tracking bug to bring the download button style consistency and associated links work over the finish line.

Overall Testing Criteria:
Test Firefox Release
Test Firefox Developer
Test Firefox Beta
Test Firefox Out of date (28, 30, 31, 32(There is some different messaging for these, especially on the sync page))

Test Chrome
Test Safari
Test IE 9+ (for download buttons, test IE6+(IIE6 if you can, else we need to ping QA. CC'ing Stephen here))

Test Android
Test iOS
Test unsupported platform

Test responsiveness
Test with JS disabled (for download buttons)
Test a11y

Test RTL (ar)
Test German
Test Italian
Test French

Test ml, my, te (there are some specific font size rules for these and I want to make sure those still work)
Run functional tests
Current IE6 sanity checks are green
Current IE7 sanity checks are green
Ran full suite in Chrome 1989 passed, 14 skipped in 2863.90 seconds

Comment 1

[Jennifer Bertsch [:jbertsch]]

Logic for the footer links are as follows (from https://bugzilla.mozilla.org/show_bug.cgi?id=1259211#c9):
The links I am referring to are:

Firefox for Other Platforms & Languages
Release Notes
Supported Devices

-------

First, these will appear only on products pages.

Secondly, for the following pages, it will show the links for the product platform, not the viewing platform:

/firefox/desktop
/firefox/all
firefox/[ver]/releasenotes/

/firefox/android
firefox/android/all/
firefox/android/[ver]/releasenotes/

/firefox/ios
firefox/ios/]ver]/releasenotes/

firefox/developer/
firefox/developer/all/
firefox/[ver]/auroranotes/

i.e. If viewing /firefox/desktop on an Android device, the links in the footer will still be for desktop Firefox. Viewing /firefox/android will show the Firefox for Android links even when viewed on a desktop browser.

For:

/firefox/new/?scene=1
/firefox/new/?scene=2

The links in the footer will match the viewing platform so, viewing the page on Android, will show links for Android, viewing on desktop will show desktop etc.

These links will not be shown on any other pages.

Comment 2

[Jennifer Bertsch [:jbertsch]]

Next steps:
*mike to move stephen's bugs to block this new tracking bug(https://bugzilla.mozilla.org/showdependencytree.cgi?id=1259211&hide_resolved=1)
*ask holly and mham to help with visual testing and file bugs against this tracker using https://docs.google.com/spreadsheets/d/1n7HoDdw7n96edOg158OlWMplsfdSx_PKHSelIecCSeg/edit#gid=0 as a guide
*schalk will close first open pr in favor of second pr
*second pr will have all open changes and schalk will rebase and push to branch on mozilla
*demo4 will become the source of truth for testing (not use the autodeploy demo servers)
*alex can begin looking at pages on friday for additional breaks/tweaks
*check back in on wednesday standup

Comment 3

[Jonathan Petto [:jpetto]]

For historical purposes, old Google doc containing (now resolved) bugs/issues is here:

https://docs.google.com/document/d/1F8q6nPDba8ArPbaOq3IVyTF8iUfLtEr2D1YxYODetU4/

Comment 4

[Schalk Neethling [:espressive]]

Current working branch:
https://github.com/schalkneethling/bedrock/tree/bug1213372-download-button-rework

Comment 5

[Schalk Neethling [:espressive]]

Adding to https://bugzilla.mozilla.org/show_bug.cgi?id=1268572#c0

All tests pass in Firefox running against demo4 as well.

=================== 108 passed, 25 skipped in 794.03 seconds ===================
Recording test results
Finished: SUCCESS

Comment 6

[Schalk Neethling [:espressive]]

In fact running against Fx locally, this is the tally:
1977 passed, 25 skipped in 1791.99 seconds

Comment 7

[Alex Gibson [:agibson]]

The new working branch for this is now up on the mozilla bedrock repo:

https://github.com/mozilla/bedrock/tree/bug1213372-download-button-rework

Comment 8

[Alex Gibson [:agibson]]

All the new download buttons on a single page:

https://www-demo4.allizom.org/en-US/styleguide/all-download-buttons/

Comment 9

[Jennifer Bertsch [:jbertsch]]

(In reply to Jennifer Bertsch [:jbertsch] from comment #1)
> Logic for the footer links are as follows (from
> https://bugzilla.mozilla.org/show_bug.cgi?id=1259211#c9):
> The links I am referring to are:
> 
> Firefox for Other Platforms & Languages
> Release Notes
> Supported Devices
> 
> -------
> 
> First, these will appear only on products pages.
> 
> Secondly, for the following pages, it will show the links for the product
> platform, not the viewing platform:
> 
> /firefox/desktop
> /firefox/all
> firefox/[ver]/releasenotes/
> 
> /firefox/android
> firefox/android/all/
> firefox/android/[ver]/releasenotes/
> 
> /firefox/ios
> firefox/ios/]ver]/releasenotes/
> 
> firefox/developer/
> firefox/developer/all/
> firefox/[ver]/auroranotes/
> 
> i.e. If viewing /firefox/desktop on an Android device, the links in the
> footer will still be for desktop Firefox. Viewing /firefox/android will show
> the Firefox for Android links even when viewed on a desktop browser.
> 
> For:
> 
> /firefox/new/?scene=1
> /firefox/new/?scene=2
> 
> The links in the footer will match the viewing platform so, viewing the page
> on Android, will show links for Android, viewing on desktop will show
> desktop etc.
> 
> These links will not be shown on any other pages.

To clarify, the All, Release Notes, and Supported devices links do not need to appear in the footer on the "feature" pages (sync, hello, private-browsing)

Comment 10

[Kohei Yoshino [:kohei]]

Just saw demo4. I think the current "Firefox for Other Platforms & Languages" link on /firefox/new/ is confusing, because

* The download button doesn't say anything about the currently offered platform and language.
* There is the "Other languages" selector just below the link.

Proposal: Change the label to "Firefox for All Platforms & Languages"

Comment 11

[Alex Gibson [:agibson]]

(In reply to Kohei Yoshino [:kohei] from comment #10)
> Just saw demo4. I think the current "Firefox for Other Platforms &
> Languages" link on /firefox/new/ is confusing, because
> 
> * The download button doesn't say anything about the currently offered
> platform and language.
> * There is the "Other languages" selector just below the link.
> 
> Proposal: Change the label to "Firefox for All Platforms & Languages"

This is a valid point. Sadly, we have already exposed string for l10n here.

Thoughts Jen, Holly?

Comment 12

[Kohei Yoshino [:kohei]]

I should have checked the work earlier ;)

One more thing I have noticed: the "Firefox Privacy" link below the download button may also be confusing. It sounds like a feature name like Firefox Sync or Firefox Hello. Because the context is clear, it's about Firefox, so the link could simply say "Privacy Notice" instead.

Comment 13

[Alex Gibson [:agibson]]

Fixed and merged to master in pull: https://github.com/mozilla/bedrock/pull/4102