Closed Bug 1268588 Opened 3 years ago Closed 3 years ago

Missing space after the word "count" in error message for crashtest/reftest assertion count mismatch ("assertion count2 is less than expected 3 to 8 assertions"

Categories

(Testing :: Reftest, defect)

Version 3
defect
Not set

Tracking

(firefox48 fixed, firefox49 fixed)

RESOLVED FIXED
mozilla49
Tracking Status
firefox48 --- fixed
firefox49 --- fixed

People

(Reporter: dholbert, Assigned: dholbert)

References

Details

Attachments

(1 file)

I just pushed a Try run, which happened to change the number of assertions on a crashtest.  This triggered an error message in the test output (correctly), but the error message is missing a space.

STR: 
 1. Push a patch that changes the number of assertions that some reftest/crashtest causes (outside of its threshold, so that it'll get reported).
 2. Look at the resulting test failure message on TreeHerder.

ACTUAL RESULTS:
Something like: "assertion count2 is less than expected 3 to 8 assertions"
Note missing space ------------^^

EXPECTED REUSLTS:
Space between "count" and the number.

Here's my Try run where I triggered this:
https://treeherder.mozilla.org/#/jobs?repo=try&revision=6a7ce65ea06d&selectedJob=20080737
...and here's the specific log showing the error message with the typo:
https://treeherder.mozilla.org/logviewer.html#?job_id=20081564&repo=try
Summary: Missing space in error message for crashtest/reftest assertion count mismatch ("assertion count2 is less than expected 3 to 8 assertions" → Missing space after the word "count" in error message for crashtest/reftest assertion count mismatch ("assertion count2 is less than expected 3 to 8 assertions"
I think this comes from this line:
http://mxr.mozilla.org/mozilla-central/source/layout/tools/reftest/reftest.jsm?rev=bc92894e7890#1828

> 1827             gDumpFn("REFTEST TEST-UNEXPECTED-PASS | " + gURLs[0].prettyPath +
> 1828                     " | assertion count" + numAsserts + " is less than " +
                                              ^
Missing space --------------------------------^
Blocks: 1267020
Patch posted. Just adds a space after the word "count" at the point highlighted in comment 1.
Assignee: nobody → dholbert
Comment on attachment 8746625 [details]
MozReview Request: Bug 1268588: Add missing space to "assertion count[...] is less than expected" reftest log message. r?gbrown

https://reviewboard.mozilla.org/r/49497/#review46333

Thanks!
Attachment #8746625 - Flags: review?(gbrown) → review+
https://hg.mozilla.org/mozilla-central/rev/b083e01f57a1
Status: NEW → RESOLVED
Closed: 3 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla49
You need to log in before you can comment on or make changes to this bug.