bugzilla.mozilla.org has resumed normal operation. Attachments prior to 2014 will be unavailable for a few days. This is tracked in Bug 1475801.
Please report any other irregularities here.

Back button history menu colors are incorrect

VERIFIED FIXED in Firefox 47

Status

()

Firefox for Android
General
VERIFIED FIXED
2 years ago
2 years ago

People

(Reporter: mcomella, Assigned: mcomella)

Tracking

(Blocks: 1 bug, {regression})

47 Branch
Firefox 49
All
Android
regression
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(firefox46 unaffected, firefox47+ verified, firefox48+ verified, firefox49+ verified, fennec47+)

Details

MozReview Requests

()

Submitter Diff Changes Open Issues Last Updated
Loading...
Error loading review requests:

Attachments

(3 attachments)

Created attachment 8746639 [details]
screenshot of issue

STR:
1) On a page, long press the back button
2) Tap on an item

Expected: One color
Actual multi-color

Likely caused by AppCompat changes (bug 1220309) which is in 48.

Kevin, can you check if this affects 48 & 47?
Flags: needinfo?(kbrosnan)
This should be the toolbar grey pressed right? #D7D7DC
I can't reproduce this on a Nexus 5x running N preview.
I tried a few more devices and cannot reproduce.
Flags: needinfo?(kbrosnan) → needinfo?(michael.l.comella)
I can reproduce this on Nightly (GS5) and my local builds (GS4 & N9). Have you tried any of those?
Flags: needinfo?(michael.l.comella) → needinfo?(kbrosnan)
I had tried a GS5 before, I just missed a step. This is a regression in 47.
tracking-fennec: ? → 47+
status-firefox46: --- → unaffected
status-firefox47: --- → affected
status-firefox48: --- → affected
status-firefox49: --- → affected
tracking-firefox47: --- → ?
tracking-firefox48: --- → ?
tracking-firefox49: --- → ?
Flags: needinfo?(kbrosnan)
Keywords: regression, regressionwindow-wanted
Regression:

29-02-2016 not affected
01-03-2016 affected

pushlog: http://hg.mozilla.org/mozilla-central/pushloghtml?fromchange=9da51cb4974e03cdd8fa45a34086fe1033abfeaf&tochange=8ef94be995a453f5c464278c53478ba8c8554f81

Is it Bug 1194033 - Change color of pressed state for list items in home panels to about_page_header_grey ?
Keywords: regressionwindow-wanted
Mike you reviewed this.
Assignee: nobody → michael.l.comella
Blocks: 1194033
No longer blocks: 1220309
Tracking for 47/48/49. Please request uplift when you have a patch if you think it safe. Thanks!
tracking-firefox47: ? → +
tracking-firefox48: ? → +
tracking-firefox49: ? → +
Created attachment 8750983 [details]
MozReview Request: Bug 1268603 - Set history background color to @null. r=ahunt

See added comment (and bug it references) for details.

Review commit: https://reviewboard.mozilla.org/r/51725/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/51725/
Attachment #8750983 - Flags: review?(ahunt)

Comment 10

2 years ago
Comment on attachment 8750983 [details]
MozReview Request: Bug 1268603 - Set history background color to @null. r=ahunt

https://reviewboard.mozilla.org/r/51725/#review48863
Attachment #8750983 - Flags: review?(ahunt) → review+
Comment on attachment 8750983 [details]
MozReview Request: Bug 1268603 - Set history background color to @null. r=ahunt

Approval Request Comment
[Feature/regressing bug #]: bug 1194033.
[User impact if declined]: Users will see a super ugly pressed state in the back history menu.
[Describe test coverage new/current, TreeHerder]: Local.
[Risks and why]: Extremely - we override & remove the background directly in the view that has the issues. Worst case: we make it look bad in a different way.
[String/UUID change made/needed]: None
Attachment #8750983 - Flags: approval-mozilla-beta?
Attachment #8750983 - Flags: approval-mozilla-aurora?

Comment 13

2 years ago
bugherder
https://hg.mozilla.org/mozilla-central/rev/b3a1f3f965fb
Status: NEW → RESOLVED
Last Resolved: 2 years ago
status-firefox49: affected → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 49
Comment on attachment 8750983 [details]
MozReview Request: Bug 1268603 - Set history background color to @null. r=ahunt

Recent regression in Fx47, Aurora48+, Beta47+
Attachment #8750983 - Flags: approval-mozilla-beta?
Attachment #8750983 - Flags: approval-mozilla-beta+
Attachment #8750983 - Flags: approval-mozilla-aurora?
Attachment #8750983 - Flags: approval-mozilla-aurora+

Comment 15

2 years ago
bugherderuplift
https://hg.mozilla.org/releases/mozilla-aurora/rev/1836352e5932
status-firefox48: affected → fixed

Comment 16

2 years ago
bugherderuplift
https://hg.mozilla.org/releases/mozilla-beta/rev/1b9f41637fb2
status-firefox47: affected → fixed

Comment 17

2 years ago
Created attachment 8753264 [details]
Screenshot_2016-05-17-11-28-59.png

Tested using:
Device: Huawei Honor (Android 5.1.1)
Build: Firefox for Android Beta - 47.0b6 and Aurora - 48.0a2(2016-05-15)

Updated

2 years ago
status-firefox47: fixed → verified
status-firefox48: fixed → verified
status-firefox49: fixed → verified
Version: unspecified → 47 Branch

Comment 18

2 years ago
I'm changing the status to verified fixed considering that the bug is verified on all versions.
Status: RESOLVED → VERIFIED
You need to log in before you can comment on or make changes to this bug.