Closed Bug 1268603 Opened 5 years ago Closed 5 years ago

Back button history menu colors are incorrect

Categories

(Firefox for Android Graveyard :: General, defect)

47 Branch
All
Android
defect
Not set
normal

Tracking

(firefox46 unaffected, firefox47+ verified, firefox48+ verified, firefox49+ verified, fennec47+)

VERIFIED FIXED
Firefox 49
Tracking Status
firefox46 --- unaffected
firefox47 + verified
firefox48 + verified
firefox49 + verified
fennec 47+ ---

People

(Reporter: mcomella, Assigned: mcomella)

References

Details

(Keywords: regression)

Attachments

(3 files)

Attached image screenshot of issue
STR:
1) On a page, long press the back button
2) Tap on an item

Expected: One color
Actual multi-color

Likely caused by AppCompat changes (bug 1220309) which is in 48.

Kevin, can you check if this affects 48 & 47?
Flags: needinfo?(kbrosnan)
This should be the toolbar grey pressed right? #D7D7DC
I can't reproduce this on a Nexus 5x running N preview.
I tried a few more devices and cannot reproduce.
Flags: needinfo?(kbrosnan) → needinfo?(michael.l.comella)
I can reproduce this on Nightly (GS5) and my local builds (GS4 & N9). Have you tried any of those?
Flags: needinfo?(michael.l.comella) → needinfo?(kbrosnan)
I had tried a GS5 before, I just missed a step. This is a regression in 47.
tracking-fennec: ? → 47+
Flags: needinfo?(kbrosnan)
Regression:

29-02-2016 not affected
01-03-2016 affected

pushlog: http://hg.mozilla.org/mozilla-central/pushloghtml?fromchange=9da51cb4974e03cdd8fa45a34086fe1033abfeaf&tochange=8ef94be995a453f5c464278c53478ba8c8554f81

Is it Bug 1194033 - Change color of pressed state for list items in home panels to about_page_header_grey ?
Mike you reviewed this.
Assignee: nobody → michael.l.comella
Blocks: 1194033
No longer blocks: 1220309
Tracking for 47/48/49. Please request uplift when you have a patch if you think it safe. Thanks!
Comment on attachment 8750983 [details]
MozReview Request: Bug 1268603 - Set history background color to @null. r=ahunt

https://reviewboard.mozilla.org/r/51725/#review48863
Attachment #8750983 - Flags: review?(ahunt) → review+
Comment on attachment 8750983 [details]
MozReview Request: Bug 1268603 - Set history background color to @null. r=ahunt

Approval Request Comment
[Feature/regressing bug #]: bug 1194033.
[User impact if declined]: Users will see a super ugly pressed state in the back history menu.
[Describe test coverage new/current, TreeHerder]: Local.
[Risks and why]: Extremely - we override & remove the background directly in the view that has the issues. Worst case: we make it look bad in a different way.
[String/UUID change made/needed]: None
Attachment #8750983 - Flags: approval-mozilla-beta?
Attachment #8750983 - Flags: approval-mozilla-aurora?
https://hg.mozilla.org/mozilla-central/rev/b3a1f3f965fb
Status: NEW → RESOLVED
Closed: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 49
Comment on attachment 8750983 [details]
MozReview Request: Bug 1268603 - Set history background color to @null. r=ahunt

Recent regression in Fx47, Aurora48+, Beta47+
Attachment #8750983 - Flags: approval-mozilla-beta?
Attachment #8750983 - Flags: approval-mozilla-beta+
Attachment #8750983 - Flags: approval-mozilla-aurora?
Attachment #8750983 - Flags: approval-mozilla-aurora+
Tested using:
Device: Huawei Honor (Android 5.1.1)
Build: Firefox for Android Beta - 47.0b6 and Aurora - 48.0a2(2016-05-15)
Version: unspecified → 47 Branch
I'm changing the status to verified fixed considering that the bug is verified on all versions.
Status: RESOLVED → VERIFIED
Product: Firefox for Android → Firefox for Android Graveyard
You need to log in before you can comment on or make changes to this bug.