Closed Bug 1268603 Opened 5 years ago Closed 5 years ago
Back button history menu colors are incorrect
177.34 KB, image/png
58 bytes, text/x-review-board-request
135.52 KB, image/png
STR: 1) On a page, long press the back button 2) Tap on an item Expected: One color Actual multi-color Likely caused by AppCompat changes (bug 1220309) which is in 48. Kevin, can you check if this affects 48 & 47?
This should be the toolbar grey pressed right? #D7D7DC
I can't reproduce this on a Nexus 5x running N preview.
I tried a few more devices and cannot reproduce.
Flags: needinfo?(kbrosnan) → needinfo?(michael.l.comella)
I can reproduce this on Nightly (GS5) and my local builds (GS4 & N9). Have you tried any of those?
Flags: needinfo?(michael.l.comella) → needinfo?(kbrosnan)
I had tried a GS5 before, I just missed a step. This is a regression in 47.
tracking-fennec: ? → 47+
Regression: 29-02-2016 not affected 01-03-2016 affected pushlog: http://hg.mozilla.org/mozilla-central/pushloghtml?fromchange=9da51cb4974e03cdd8fa45a34086fe1033abfeaf&tochange=8ef94be995a453f5c464278c53478ba8c8554f81 Is it Bug 1194033 - Change color of pressed state for list items in home panels to about_page_header_grey ?
Tracking for 47/48/49. Please request uplift when you have a patch if you think it safe. Thanks!
5 years ago
See added comment (and bug it references) for details. Review commit: https://reviewboard.mozilla.org/r/51725/diff/#index_header See other reviews: https://reviewboard.mozilla.org/r/51725/
Attachment #8750983 - Flags: review?(ahunt)
Comment on attachment 8750983 [details] MozReview Request: Bug 1268603 - Set history background color to @null. r=ahunt https://reviewboard.mozilla.org/r/51725/#review48863
Attachment #8750983 - Flags: review?(ahunt) → review+
https://hg.mozilla.org/integration/fx-team/rev/b3a1f3f965fb47e1499897348ff9a420fd3579a9 Bug 1268603 - Set history background color to @null. r=ahunt
Comment on attachment 8750983 [details] MozReview Request: Bug 1268603 - Set history background color to @null. r=ahunt Approval Request Comment [Feature/regressing bug #]: bug 1194033. [User impact if declined]: Users will see a super ugly pressed state in the back history menu. [Describe test coverage new/current, TreeHerder]: Local. [Risks and why]: Extremely - we override & remove the background directly in the view that has the issues. Worst case: we make it look bad in a different way. [String/UUID change made/needed]: None
Comment on attachment 8750983 [details] MozReview Request: Bug 1268603 - Set history background color to @null. r=ahunt Recent regression in Fx47, Aurora48+, Beta47+
Tested using: Device: Huawei Honor (Android 5.1.1) Build: Firefox for Android Beta - 47.0b6 and Aurora - 48.0a2(2016-05-15)
I'm changing the status to verified fixed considering that the bug is verified on all versions.
Status: RESOLVED → VERIFIED
Product: Firefox for Android → Firefox for Android Graveyard
You need to log in before you can comment on or make changes to this bug.