Closed Bug 1268606 Opened 4 years ago Closed 4 years ago

URL bar text selection action bar is incorrectly colored

Categories

(Firefox for Android :: General, defect)

All
Android
defect
Not set

Tracking

()

VERIFIED FIXED
Firefox 49
Tracking Status
firefox47 --- unaffected
firefox48 + verified
firefox49 + verified
relnote-firefox --- -
fennec 48+ ---

People

(Reporter: mcomella, Assigned: mcomella)

References

Details

(Keywords: regression)

Attachments

(2 files)

Attached image Screenshot of issue
STR:
1) Click toolbar
2) Tap into toolbar to dismiss select-all
3) Long-press to select all

Expected: Grey action bar with dark icons
Actual: black action bar with dark grey icons

Likely due to appcompat changes (bug 1220309) which landed in 48. Kevin, can you check if this affects 48 & 47?
Flags: needinfo?(kbrosnan)
tracking-fennec: --- → ?
[Tracking Requested - why for this release]: regression
Tracking for 48/49 as this is a visible issue which makes it more difficult to see the bar.
The animation for the new Action Bar is too impressively smooth to ship in the framework so I'm going to blame AppCompat (it's also in the regression log from comment 3). We're already blocking it – bug 1220309.
Assignee: nobody → michael.l.comella
tracking-fennec: ? → 48+
Comment on attachment 8755686 [details]
MozReview Request: Bug 1268606 - Correct action bar style for url bar. r=liuche

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/54744/diff/1-2/
Comment on attachment 8755686 [details]
MozReview Request: Bug 1268606 - Correct action bar style for url bar. r=liuche

https://reviewboard.mozilla.org/r/54744/#review51408

Cool - do you have a summary resource for appcompat? I've just been able to find scattered links and references everywhere, for solving specific problems.
Attachment #8755686 - Flags: review?(liuche) → review+
(In reply to Chenxia Liu [:liuche] from comment #7)
> Cool - do you have a summary resource for appcompat? I've just been able to
> find scattered links and references everywhere, for solving specific
> problems.

Unfortunately, no – I just tried a bunch of different combinations of attrs until it worked. StackOverflow is also *very* wrong *very* often and we do so much custom bullshit (e.g. we have a custom action bar) that many of the built-in attributes are unused.

I think reading the source is your best best. See [1] for a list of all the supported "AppCompat" attributes (which often override the ones provided by the framework by removing "android:"). Then, in Intellij, you can step into the support library source with go to definition on styles to see what attrs they set & override. For this example, I overrode ThemeOverlay.AppCompat.ActionBar so I could jump into their definition & see what changed between that and ThemeOverlay.AppCompat.ActionBar.Dark (or whatever it is). Once you're in that file, you can scroll around to find other relevant AppCompat styles.

[1]: http://androidxref.com/6.0.0_r1/xref/frameworks/support/v7/appcompat/res/values/attrs.xml
Comment on attachment 8755686 [details]
MozReview Request: Bug 1268606 - Correct action bar style for url bar. r=liuche

Approval Request Comment
[Feature/regressing bug #]: bug 1220309
[User impact if declined]: Users will have an action bar inconsistently styled from the rest of our app.
[Describe test coverage new/current, TreeHerder]: Tested locally on N4.
[Risks and why]: Since we're just changing XML attrs, in the worst case, we style the action bar incorrectly (particularly on different device versions, but appcompat is supposed to fix that).
[String/UUID change made/needed]: None
Attachment #8755686 - Flags: approval-mozilla-aurora?
https://hg.mozilla.org/mozilla-central/rev/3902c1e03594
Status: NEW → RESOLVED
Closed: 4 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 49
Tested using:
Device: Moto X (Android 4.4.)
Build: Firefox for Android 49.0a1 (2016-05-26)

URL bar text selection action bar is now correctly colored: http://i.imgur.com/eUqaCAU.png
But caused Bug 1275880 - "Settings" header is incorrectly colored.
Comment on attachment 8755686 [details]
MozReview Request: Bug 1268606 - Correct action bar style for url bar. r=liuche

Fix a regression, takign it
Attachment #8755686 - Flags: approval-mozilla-aurora? → approval-mozilla-aurora+
Release Note Request (optional, but appreciated)
[Why is this notable]:
[Suggested wording]: Bugfix for URL bar text selection action bar incorrectly colored
[Links (documentation, blog post, etc)]:
relnote-firefox: --- → ?
This is a regression that was fixed... I don't think this needs a release note, since the problem was never actually in release.
Relnote - based on Comment 16.
Version: unspecified → Trunk
Verified as fixed using Galaxy Note 5(6.0.1) with 48 Release and 49.0b11 Beta.
Status: RESOLVED → VERIFIED
You need to log in before you can comment on or make changes to this bug.