1268620 - Let's change the selection color from #f5f7fa to white for better contrast.

Status: RESOLVED DUPLICATE of bug 1248621

(DevTools :: General, enhancement, P2)

Description

[Helen V. Holmes (:helenvholmes) (:✨)]

(In reply to Helen V. Holmes (:helenvholmes) (:✨)(pls ni?) from comment #13)
> Created attachment 8746665 [details] [diff] [review]
> dark-refresh.patch
> 
> (In reply to Brian Grinstead [:bgrins] from comment #12)
> > @@ +71,2 @@
> > >    --theme-selection-background-semitransparent: rgba(29, 79, 115, .5);
> > > +  --theme-selection-color: white;
> > 
> > Honestly, this selection-color is one thing I'd avoid changing in this
> > patch, since it's currently the same between both themes, and is hardcoded
> > in various places:
> > https://dxr.mozilla.org/mozilla-central/
> > search?q=f5f7fa&redirect=true&case=false.  I think that should be cleaned up
> > but if it were me working on it I'd rather do that in another bug.  If
> > that's good with you, then can you roll back all changes of #f5f7fa?

Comment 1

[Sonia Singla :soniasingla]

I would like to work on this issue.

Thanks
Sonia

Comment 2

[Gabriel Luong [:gl] (ΦωΦ)]

(In reply to Sonia from comment #1)

I would like to work on this issue.

Thanks
Sonia

Hi Sonia, thank you for volunteering to work on this issue. I believe this is actually already fixed.

Looking at https://searchfox.org/mozilla-central/source/devtools/client/themes/variables.css#43, it seems the --theme-selection-color is already set to white, and was fixed in Bug 1248621.

Comment 3

[Gabriel Luong [:gl] (ΦωΦ)]

.

Comment 4

[Sonia Singla :soniasingla]

Thanks for the confirmation !