Closed
Bug 1268620
Opened 8 years ago
Closed 5 years ago
Let's change the selection color from #f5f7fa to white for better contrast.
Categories
(DevTools :: General, enhancement, P2)
DevTools
General
Tracking
(Not tracked)
RESOLVED
DUPLICATE
of bug 1248621
People
(Reporter: hholmes, Unassigned)
References
Details
(In reply to Helen V. Holmes (:helenvholmes) (:✨)(pls ni?) from comment #13) > Created attachment 8746665 [details] [diff] [review] > dark-refresh.patch > > (In reply to Brian Grinstead [:bgrins] from comment #12) > > @@ +71,2 @@ > > > --theme-selection-background-semitransparent: rgba(29, 79, 115, .5); > > > + --theme-selection-color: white; > > > > Honestly, this selection-color is one thing I'd avoid changing in this > > patch, since it's currently the same between both themes, and is hardcoded > > in various places: > > https://dxr.mozilla.org/mozilla-central/ > > search?q=f5f7fa&redirect=true&case=false. I think that should be cleaned up > > but if it were me working on it I'd rather do that in another bug. If > > that's good with you, then can you roll back all changes of #f5f7fa?
Reporter | ||
Updated•8 years ago
|
Severity: normal → enhancement
Priority: -- → P2
Updated•6 years ago
|
Product: Firefox → DevTools
Comment 1•5 years ago
|
||
I would like to work on this issue.
Thanks
Sonia
Comment 2•5 years ago
•
|
||
(In reply to Sonia from comment #1)
I would like to work on this issue.
Thanks
Sonia
Hi Sonia, thank you for volunteering to work on this issue. I believe this is actually already fixed.
Looking at https://searchfox.org/mozilla-central/source/devtools/client/themes/variables.css#43, it seems the --theme-selection-color
is already set to white, and was fixed in Bug 1248621.
Status: NEW → RESOLVED
Closed: 5 years ago
Resolution: --- → DUPLICATE
Comment 3•5 years ago
•
|
||
.
Comment 4•5 years ago
|
||
Thanks for the confirmation !
You need to log in
before you can comment on or make changes to this bug.
Description
•