1268622 - Talos should specify whether a run is "e10s" as a special property of the suite

Status: RESOLVED FIXED

(Testing :: Talos, defect)

Description

[William Lachance (:wlach)]

Right now perfherder categorizes talos data as being "e10s" (i.e. the test was run with e10s enabled) by looking at its job symbol, but this is a bit of a hack:

https://github.com/mozilla/treeherder/blob/e7e98d0155e17198b85a85af2bcb9eaa40d9a44b/treeherder/etl/perf.py#L35

Instead, it should specify `extraOptions: ["e10s"]` on the suite level of the PERFHERDER_DATA object it spits out. Once this is done, we can remove yet another special case from inside Perfherder itself.

It's been a while since I've touched Talos, but I suspect this might be a good first bug for someone to pick up.

Comment 1

[Joel Maher ( :jmaher ) (UTC -8)]

wlach, what about pgo?

Comment 2

[William Lachance (:wlach)]

(In reply to Joel Maher (:jmaher) from comment #1)
> wlach, what about pgo?

That's handled via the (separate) option collection property in perfherder already.

Comment 3

[Robert Wood [:rwood]]

Attachment: MozReview Request: Bug 1268622 - Talos should specify whether a run is e10s as a special property of the suite; r?jmaher

Review commit: https://reviewboard.mozilla.org/r/51711/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/51711/

Comment 4

[Joel Maher ( :jmaher ) (UTC -8)]

Comment on attachment 8750956 [details]
MozReview Request: Bug 1268622 - Talos should specify whether a run is e10s as a special property of the suite; r?jmaher

https://reviewboard.mozilla.org/r/51711/#review48761

do this adjust the perfherder_data output structure at all?  If so, I will be happy to r+ this.

Comment 5

[William Lachance (:wlach)]

(In reply to Joel Maher (:jmaher) from comment #4)
> Comment on attachment 8750956 [details]
> MozReview Request: Bug 1268622 - Talos should specify whether a run is e10s
> as a special property of the suite; r?jmaher
> 
> https://reviewboard.mozilla.org/r/51711/#review48761
> 
> do this adjust the perfherder_data output structure at all?  If so, I will
> be happy to r+ this.

It appears to do the right thing:

https://treeherder.mozilla.org/logviewer.html#?job_id=20637872&repo=try#L1374

Note for the future: Please run patches like this by me explicitly, since incorrectly formatted output has the potential to cause problems (it has in the past).

Comment 6

[Joel Maher ( :jmaher ) (UTC -8)]

Comment on attachment 8750956 [details]
MozReview Request: Bug 1268622 - Talos should specify whether a run is e10s as a special property of the suite; r?jmaher

https://reviewboard.mozilla.org/r/51711/#review48787

thanks :wlach for clarifying.  It is hard to remember all the right places to adjust or ask for additional reviews.  I should have know to run this by your :wlach, between rwood and myself we can do better in the future.

Comment 7

[Robert Wood [:rwood]]

https://reviewboard.mozilla.org/r/51711/#review48761

Yes, see "extraOptions": ["e10s"] for each suite:

https://treeherder.mozilla.org/logviewer.html#?job_id=20637870&repo=try#L1405

If the test run is non-e10s then the output structure is not changed, for example:
https://treeherder.mozilla.org/logviewer.html#?job_id=20637876&repo=try#L1359

The same output modification is reflected in the local.json when running locally i.e. --develop mode.

Comment 8

[Pulsebot]

https://hg.mozilla.org/integration/mozilla-inbound/rev/8a6a980d3953

Comment 9

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/8a6a980d3953