Talos should specify whether a run is "e10s" as a special property of the suite

RESOLVED FIXED in Firefox 49

Status

Testing
Talos
RESOLVED FIXED
2 years ago
2 years ago

People

(Reporter: wlach, Assigned: rwood)

Tracking

(Blocks: 1 bug)

unspecified
mozilla49
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(e10s+, firefox49 fixed)

Details

(Whiteboard: [talos_wishlist])

MozReview Requests

Submitter Diff Changes Open Issues Last Updated
Loading...
Error loading review requests:

Attachments

(1 attachment)

Right now perfherder categorizes talos data as being "e10s" (i.e. the test was run with e10s enabled) by looking at its job symbol, but this is a bit of a hack:

https://github.com/mozilla/treeherder/blob/e7e98d0155e17198b85a85af2bcb9eaa40d9a44b/treeherder/etl/perf.py#L35

Instead, it should specify `extraOptions: ["e10s"]` on the suite level of the PERFHERDER_DATA object it spits out. Once this is done, we can remove yet another special case from inside Perfherder itself.

It's been a while since I've touched Talos, but I suspect this might be a good first bug for someone to pick up.
Whiteboard: [talos_wishlist]
wlach, what about pgo?
(In reply to Joel Maher (:jmaher) from comment #1)
> wlach, what about pgo?

That's handled via the (separate) option collection property in perfherder already.

Updated

2 years ago
Blocks: 984139
tracking-e10s: --- → +
(Assignee)

Updated

2 years ago
Assignee: nobody → rwood
Status: NEW → ASSIGNED
(Assignee)

Comment 3

2 years ago
Created attachment 8750956 [details]
MozReview Request: Bug 1268622 - Talos should specify whether a run is e10s as a special property of the suite; r?jmaher

Review commit: https://reviewboard.mozilla.org/r/51711/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/51711/
Attachment #8750956 - Flags: review?(jmaher)
Comment on attachment 8750956 [details]
MozReview Request: Bug 1268622 - Talos should specify whether a run is e10s as a special property of the suite; r?jmaher

https://reviewboard.mozilla.org/r/51711/#review48761

do this adjust the perfherder_data output structure at all?  If so, I will be happy to r+ this.
Attachment #8750956 - Flags: review?(jmaher)
(In reply to Joel Maher (:jmaher) from comment #4)
> Comment on attachment 8750956 [details]
> MozReview Request: Bug 1268622 - Talos should specify whether a run is e10s
> as a special property of the suite; r?jmaher
> 
> https://reviewboard.mozilla.org/r/51711/#review48761
> 
> do this adjust the perfherder_data output structure at all?  If so, I will
> be happy to r+ this.

It appears to do the right thing:

https://treeherder.mozilla.org/logviewer.html#?job_id=20637872&repo=try#L1374

Note for the future: Please run patches like this by me explicitly, since incorrectly formatted output has the potential to cause problems (it has in the past).
Comment on attachment 8750956 [details]
MozReview Request: Bug 1268622 - Talos should specify whether a run is e10s as a special property of the suite; r?jmaher

https://reviewboard.mozilla.org/r/51711/#review48787

thanks :wlach for clarifying.  It is hard to remember all the right places to adjust or ask for additional reviews.  I should have know to run this by your :wlach, between rwood and myself we can do better in the future.
Attachment #8750956 - Flags: review+
(Assignee)

Comment 7

2 years ago
https://reviewboard.mozilla.org/r/51711/#review48761

Yes, see "extraOptions": ["e10s"] for each suite:

https://treeherder.mozilla.org/logviewer.html#?job_id=20637870&repo=try#L1405

If the test run is non-e10s then the output structure is not changed, for example:
https://treeherder.mozilla.org/logviewer.html#?job_id=20637876&repo=try#L1359

The same output modification is reflected in the local.json when running locally i.e. --develop mode.

Comment 9

2 years ago
bugherder
https://hg.mozilla.org/mozilla-central/rev/8a6a980d3953
Status: ASSIGNED → RESOLVED
Last Resolved: 2 years ago
status-firefox49: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla49
You need to log in before you can comment on or make changes to this bug.