Closed Bug 1268752 Opened 3 years ago Closed 3 years ago

Bug fix in locating eslint with npm

Categories

(Firefox Build System :: Lint and Formatting, defect)

48 Branch
defect
Not set

Tracking

(firefox49 fixed)

RESOLVED FIXED
mozilla49
Tracking Status
firefox49 --- fixed

People

(Reporter: hectorz, Assigned: hectorz)

References

Details

Attachments

(1 file)

> NameError: global name 'minversion' is not defined
> 
>   File "d:\mozilla\gecko-dev\python/mach_commands.py", line 224, in eslint
>     if minversion:
> 

I'll submit a patch soon.
Comment on attachment 8746904 [details]
MozReview Request: Bug 1268752 - Bug fix in locating eslint with npm. r?gps

https://reviewboard.mozilla.org/r/49597/#review46861
Attachment #8746904 - Flags: review?(gps) → review+
Thanks for landing this.
https://hg.mozilla.org/mozilla-central/rev/d0fc972a906a
Status: NEW → RESOLVED
Closed: 3 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla49
Product: Testing → Firefox Build System
You need to log in before you can comment on or make changes to this bug.