Closed Bug 1268754 Opened 4 years ago Closed 4 years ago

Tweak some MFBT return values

Categories

(Core :: MFBT, defect)

defect
Not set

Tracking

()

RESOLVED FIXED
mozilla49
Tracking Status
firefox49 --- fixed

People

(Reporter: njn, Assigned: njn)

References

(Blocks 1 open bug)

Details

Attachments

(1 file)

I looked through mfbt/ for places to add MOZ_MUST_USE. I didn't find much, but
what I did find I've included here.
This patch:

- Adds MOZ_MUST_USE to AllocPolicy::checkSimulatedOOM().

- Adds MOZ_MUST_USE to LZ4::decompress() (both variants) and fixes their
  comments.

- Changes the return type of SplayTree::insert() from bool to void, because it
  always returns true and its callers don't check the return value.

- Changes the return type of SplayTree::finishInsertion() from T* to void,
  because it makes things clearer -- it was just returning the aNew argument.

- Adds MOZ_MUST_USE to a Vector::growTo() (both variants).
Attachment #8746908 - Flags: review?(Ms2ger)
Blocks: MOZ_MUST_USE
Comment on attachment 8746908 [details] [diff] [review]
Tweak some MFBT return values

Review of attachment 8746908 [details] [diff] [review]:
-----------------------------------------------------------------

lgtm
Attachment #8746908 - Flags: review?(Ms2ger) → review+
https://hg.mozilla.org/mozilla-central/rev/d32e2e690073
Status: ASSIGNED → RESOLVED
Closed: 4 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla49
You need to log in before you can comment on or make changes to this bug.