1268754 - Tweak some MFBT return values

Status: RESOLVED FIXED

(Core :: MFBT, defect)

Description

[Nicholas Nethercote [inactive]]

I looked through mfbt/ for places to add MOZ_MUST_USE. I didn't find much, but
what I did find I've included here.

Comment 1

[Nicholas Nethercote [inactive]]

Attachment: Tweak some MFBT return values

This patch:

- Adds MOZ_MUST_USE to AllocPolicy::checkSimulatedOOM().

- Adds MOZ_MUST_USE to LZ4::decompress() (both variants) and fixes their
  comments.

- Changes the return type of SplayTree::insert() from bool to void, because it
  always returns true and its callers don't check the return value.

- Changes the return type of SplayTree::finishInsertion() from T* to void,
  because it makes things clearer -- it was just returning the aNew argument.

- Adds MOZ_MUST_USE to a Vector::growTo() (both variants).

Comment 2

[:Ms2ger (he/him; ⌚ UTC+1/+2)]

Comment on attachment 8746908 [details] [diff] [review]
Tweak some MFBT return values

Review of attachment 8746908 [details] [diff] [review]:
-----------------------------------------------------------------

lgtm

Comment 3

[Nicholas Nethercote [inactive]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/d32e2e6900731d22163bcd2370ea8f75b634eb54
Bug 1268754 - Tweak some MFBT return values. r=Ms2ger.

Comment 4

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/d32e2e690073