1268803 - Make sure BroadcastChannel are separated by userContextId

Status: RESOLVED FIXED

(Core :: DOM: Security, defect)

Description

[Jonathan Hao (inactive) [:jhao]]

I tried to write a test for bug 1260907, but later I realized my test actually tests BroadcastChannel's postMessage, instead of window-to-window postMessage. Therefore, I open this bug for that.

Comment 1

[Jonathan Hao (inactive) [:jhao]]

Attachment: Make sure BroadcastChannels are separated by userContextId

Hi baku, may I ask you to review this patch? Thanks.

Comment 2

[Jonathan Hao (inactive) [:jhao]]

Attachment: Make sure BroadcastChannels are separated by userContextId

Removed trailing spaces.

Comment 3

[Andrea Marchesini [:baku]]

Comment on attachment 8746992 [details] [diff] [review]
Make sure BroadcastChannels are separated by userContextId

Review of attachment 8746992 [details] [diff] [review]:
-----------------------------------------------------------------

::: browser/components/contextualidentity/test/browser/browser_postMessage.js
@@ +21,5 @@
> +
> +add_task(function* setup() {
> +  // make sure userContext is enabled.
> +  SpecialPowers.pushPrefEnv({"set": [
> +    ["privacy.userContext.enabled", true]

There is a better way to do it. What about this:

add_task(function* setup() {
  yield new Promise((resolve) => {
    SpecialPowers.pushPrefEnv({"set": [
      ["privacy.userContext.enabled", true],
    ]}, resolve);
  });
});

Maybe file a bug to fix all the existing contextual identity browser tests.
If we do that, we can remove cleanup().

@@ +28,5 @@
> +
> +add_task(function* cleanup() {
> +  // make sure we don't leave any prefs set for the next tests
> +  registerCleanupFunction(function() {
> +    SpecialPowers.popPrefEnv();

remove this one. We don't need it if we use pushPrefEnv.

Comment 4

[Jonathan Hao (inactive) [:jhao]]

Attachment: Make sure BroadcastChannels are separated by userContextId

Thanks, baku.
I addressed your comments. I also added some comments in the test, and change the filename from browser_postMessage.js to browser_broadcastchannel.js to avoid confusion.

Comment 5

[Jonathan Hao (inactive) [:jhao]]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=f54e7472baa2

Comment 6

[Pulsebot]

https://hg.mozilla.org/integration/mozilla-inbound/rev/afc86294a605

Comment 7

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/afc86294a605