Closed Bug 1268811 Opened 9 years ago Closed 9 years ago

Refactor code and remove akita-sidebar comments in sidebar.jsx

Categories

(Hello (Loop) :: Client, defect, P1)

Product:
Hello (Loop)
Component:
Client
Type:
defect

Tracking

(Not tracked)

Status:
RESOLVED FIXED

People

(Reporter: mancas, Assigned: mancas)

Details

(Whiteboard: [akita])

User Story

* Tech list:
* Refactor sidebar.jsx code
** initialization code
** remove useless functions/stores/whatever
* Re-write or re-use conversation tests

Attachments

(1 file)

[loop] mancas:bug1268811 > mozilla:akita
40 bytes, text/x-github-pull-request
standard8
: review+
Details | Review
Clean up sidebar code especially the initialization part. The useless code should be removed and the "test" stuff fixed. Also the conversation tests needs to be rewritten to fit the new sidebar approach.
Attachment #8748514 - Flags: review?(standard8)
Comment on attachment 8748514 [details] [review] [loop] mancas:bug1268811 > mozilla:akita I've responded to the questions on the PR. I think there's nothing else here that needs my specific review, so I'll punt on that, and let you request review from other people when you're ready.
Attachment #8748514 - Flags: review?(standard8)
Rank: 11
Comment on attachment 8748514 [details] [review] [loop] mancas:bug1268811 > mozilla:akita I was getting an error when running |make test| but it seems to be a timing problem so if you face to it, raise your hand The error: http://pastebin.com/v34nzQDX
Attachment #8748514 - Flags: review?(dmose)
Attachment #8748514 - Flags: review?(crafuse)
Comment on attachment 8748514 [details] [review] [loop] mancas:bug1268811 > mozilla:akita Stealing reviews, as looking at other bugs, I wanted some of this to be there anyway, so I thought I'd just review it. Looks good, r=Standard8
Attachment #8748514 - Flags: review?(dmose)
Attachment #8748514 - Flags: review?(crafuse)
Attachment #8748514 - Flags: review+
Landed in akita branch: https://github.com/mozilla/loop/commit/123968f9ebbb087e0b2f02d5b7ae4e847b7bfdff
Status: ASSIGNED → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: