[TV][Home] No focus when returning from card picker mode

RESOLVED FIXED

Status

RESOLVED FIXED
2 years ago
2 years ago

People

(Reporter: Fischer, Assigned: Fischer)

Tracking

unspecified
ARM
Gonk (Firefox OS)

Firefox Tracking Flags

(blocking-b2g:2.6?)

Details

Attachments

(1 attachment)

(Assignee)

Description

2 years ago
STR:
1) Move focus to "Add folder"
2) Hit enter key to show card piker mode
3) Do nothing and just leave card picker mode

Expected result:
"Add folder" is focused

Actual result:
"Add folder" is not focused
(Assignee)

Updated

2 years ago
Assignee: nobody → fliu
No longer depends on: 1268423
(Assignee)

Updated

2 years ago
blocking-b2g: --- → 2.6?
Created attachment 8748043 [details] [review]
[gaia] Fischer-L:bug_1268825-no-focus-returning-from-crad-picker > mozilla-b2g:v2.6
(Assignee)

Comment 2

2 years ago
Comment on attachment 8748043 [details] [review]
[gaia] Fischer-L:bug_1268825-no-focus-returning-from-crad-picker > mozilla-b2g:v2.6

@Luke,

This patch fixes the issue
- No focus after returning from Card Picker mode
- Focus may be incorrect after adding new folder and returning from Card Picker mode

Thank you
Attachment #8748043 - Flags: review?(lchang)
Comment on attachment 8748043 [details] [review]
[gaia] Fischer-L:bug_1268825-no-focus-returning-from-crad-picker > mozilla-b2g:v2.6

Looks good! Thanks.
Attachment #8748043 - Flags: review?(lchang) → review+
(Assignee)

Comment 4

2 years ago
Land to v2.6: https://github.com/mozilla-b2g/gaia/commit/8429c58b80435a9df73e3015c718a803fbbfed19
Status: NEW → RESOLVED
Last Resolved: 2 years ago
Resolution: --- → FIXED
You shouldn't use promise for this purpose. It just "happens" to work, but what you do here is just yet another setTimeout().
You need to log in before you can comment on or make changes to this bug.