Closed
Bug 1268921
Opened 8 years ago
Closed 8 years ago
[e10s] Allow non-integer values to be specified for e10srollout cohort samples
Categories
(Firefox :: General, defect)
Tracking
()
RESOLVED
FIXED
Firefox 49
People
(Reporter: Felipe, Assigned: Felipe)
References
Details
Attachments
(1 file)
58 bytes,
text/x-review-board-request
|
mconley
:
review+
ritu
:
approval-mozilla-aurora+
ritu
:
approval-mozilla-beta-
|
Details |
The original code for the e10srollout system add-on used integers for the sample values in order to avoid storing a float as string and doing parseFloat, which is the traditional way to store a float in the preferences service. However, it looks like we may start with a sample < 1%, so we need to be able to specify non-integer values.
Assignee | ||
Comment 1•8 years ago
|
||
Review commit: https://reviewboard.mozilla.org/r/49777/diff/#index_header See other reviews: https://reviewboard.mozilla.org/r/49777/
Attachment #8747246 -
Flags: review?(mconley)
Comment 2•8 years ago
|
||
Comment on attachment 8747246 [details] MozReview Request: Bug 1268921 - Allow non-integer values to be specified for e10srollout cohort samples. r=mconley https://reviewboard.mozilla.org/r/49777/#review46545 LGTM
Attachment #8747246 -
Flags: review?(mconley) → review+
Comment 4•8 years ago
|
||
bugherder |
https://hg.mozilla.org/mozilla-central/rev/3b7b5c87cf2b
Status: ASSIGNED → RESOLVED
Closed: 8 years ago
status-firefox49:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 49
Assignee | ||
Comment 5•8 years ago
|
||
Comment on attachment 8747246 [details] MozReview Request: Bug 1268921 - Allow non-integer values to be specified for e10srollout cohort samples. r=mconley Approval Request Comment [Feature/regressing bug #]: e10s rollout system add-on [User impact if declined]: Currently the system add-on only allows integer values to be used in the sample size, so 1% is the min value. However, Product might want to start with a value <1%, so we need to allow floats for that [Describe test coverage new/current, TreeHerder]: landed on central [Risks and why]: small. the code converts the old integer value to a float in order to preserve the existing assignment of test/control users that is present on the current beta47 experiment. [String/UUID change made/needed]: none
Attachment #8747246 -
Flags: approval-mozilla-beta?
Attachment #8747246 -
Flags: approval-mozilla-aurora?
status-firefox47:
--- → affected
status-firefox48:
--- → affected
Comment on attachment 8747246 [details] MozReview Request: Bug 1268921 - Allow non-integer values to be specified for e10srollout cohort samples. r=mconley I think we need this in Aurora48 as e10s might be enabled by default to a small percentage of users on release. I do not think this is needed in Beta47. Please let me know if that is not the case.
Attachment #8747246 -
Flags: approval-mozilla-beta?
Attachment #8747246 -
Flags: approval-mozilla-beta-
Attachment #8747246 -
Flags: approval-mozilla-aurora?
Attachment #8747246 -
Flags: approval-mozilla-aurora+
Assignee | ||
Comment 7•8 years ago
|
||
The value on beta47 would be to start testing the new code sooner, since the add-on is only used on Beta. However I might be ok with waiting until beta48 to test this change. Let me think some more about it and I'll let you know until the end of the week.
Assignee | ||
Comment 8•8 years ago
|
||
https://hg.mozilla.org/releases/mozilla-aurora/rev/b6738ca64438
You need to log in
before you can comment on or make changes to this bug.
Description
•