make css-parsing-utils eslint-clean

RESOLVED FIXED in Firefox 49

Status

defect
RESOLVED FIXED
3 years ago
Last year

People

(Reporter: tromey, Assigned: tromey)

Tracking

(Blocks 1 bug)

unspecified
Firefox 49
Dependency tree / graph

Firefox Tracking Flags

(firefox49 fixed)

Details

Attachments

(1 attachment)

Assignee

Description

3 years ago
I noticed that css-parsing-utils is not eslint-clean.
I thought maybe it was (?) and regressed.
This bug is to fix it again and make it harder to regress.
Assignee

Comment 2

3 years ago
Comment on attachment 8747258 [details]
MozReview Request: Bug 1268974 - make css-parsing-utils eslint-clean; r=pbro

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/49785/diff/1-2/
Comment on attachment 8747258 [details]
MozReview Request: Bug 1268974 - make css-parsing-utils eslint-clean; r=pbro

https://reviewboard.mozilla.org/r/49785/#review46673
Attachment #8747258 - Flags: review?(pbrosset) → review+
Assignee

Updated

3 years ago
Keywords: checkin-needed
needs rebasing 

patching file devtools/client/shared/css-parsing-utils.js
Hunk #3 FAILED at 567
1 out of 10 hunks FAILED -- saving rejects to file devtools/client/shared/css-parsing-utils.js.rej
patch failed to apply
abort: fix up the working directory and run hg transplant --continue
Flags: needinfo?(ttromey)
Keywords: checkin-needed
Assignee

Comment 6

3 years ago
Comment on attachment 8747258 [details]
MozReview Request: Bug 1268974 - make css-parsing-utils eslint-clean; r=pbro

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/49785/diff/2-3/
Attachment #8747258 - Attachment description: MozReview Request: Bug 1268974 - make css-parsing-utils eslint-clean; r?pbro → MozReview Request: Bug 1268974 - make css-parsing-utils eslint-clean; r=pbro
Assignee

Comment 7

3 years ago
Rebased.
Flags: needinfo?(ttromey)
Keywords: checkin-needed
hm still fails 

applying b464a023b3d7
patching file devtools/client/shared/css-parsing-utils.js
Hunk #3 FAILED at 567
1 out of 10 hunks FAILED -- saving rejects to file devtools/client/shared/css-parsing-utils.js.rej
patch failed to apply
abort: fix up the working directory and run hg transplant --continue

can you take a look ?
Flags: needinfo?(ttromey)
Keywords: checkin-needed
Assignee

Comment 10

3 years ago
I rebased and pushed it.
Flags: needinfo?(ttromey)

Comment 11

3 years ago
bugherder
https://hg.mozilla.org/mozilla-central/rev/26fca47bf8db
Status: ASSIGNED → RESOLVED
Closed: 3 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 49

Updated

Last year
Product: Firefox → DevTools
You need to log in before you can comment on or make changes to this bug.