Closed Bug 1268974 Opened 9 years ago Closed 9 years ago

make css-parsing-utils eslint-clean

Categories

(DevTools :: Inspector, defect)

Product:
DevTools
Component:
Inspector
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

(firefox49 fixed)

Status:
RESOLVED FIXED
Milestone:
Firefox 49
Tracking Flags:
Tracking Status
firefox49 --- fixed

People

(Reporter: tromey, Assigned: tromey)

References

Details

Attachments

(1 file)

MozReview Request: Bug 1268974 - make css-parsing-utils eslint-clean; r=pbro
58 bytes, text/x-review-board-request
pbro
: review+
Details
I noticed that css-parsing-utils is not eslint-clean. I thought maybe it was (?) and regressed. This bug is to fix it again and make it harder to regress.
Comment on attachment 8747258 [details] MozReview Request: Bug 1268974 - make css-parsing-utils eslint-clean; r=pbro Review request updated; see interdiff: https://reviewboard.mozilla.org/r/49785/diff/1-2/
Comment on attachment 8747258 [details] MozReview Request: Bug 1268974 - make css-parsing-utils eslint-clean; r=pbro https://reviewboard.mozilla.org/r/49785/#review46673
Attachment #8747258 - Flags: review?(pbrosset) → review+
Keywords: checkin-needed
needs rebasing patching file devtools/client/shared/css-parsing-utils.js Hunk #3 FAILED at 567 1 out of 10 hunks FAILED -- saving rejects to file devtools/client/shared/css-parsing-utils.js.rej patch failed to apply abort: fix up the working directory and run hg transplant --continue
Flags: needinfo?(ttromey)
Keywords: checkin-needed
Comment on attachment 8747258 [details] MozReview Request: Bug 1268974 - make css-parsing-utils eslint-clean; r=pbro Review request updated; see interdiff: https://reviewboard.mozilla.org/r/49785/diff/2-3/
Attachment #8747258 - Attachment description: MozReview Request: Bug 1268974 - make css-parsing-utils eslint-clean; r?pbro → MozReview Request: Bug 1268974 - make css-parsing-utils eslint-clean; r=pbro
Rebased.
Flags: needinfo?(ttromey)
Keywords: checkin-needed
hm still fails applying b464a023b3d7 patching file devtools/client/shared/css-parsing-utils.js Hunk #3 FAILED at 567 1 out of 10 hunks FAILED -- saving rejects to file devtools/client/shared/css-parsing-utils.js.rej patch failed to apply abort: fix up the working directory and run hg transplant --continue can you take a look ?
Flags: needinfo?(ttromey)
Keywords: checkin-needed
I rebased and pushed it.
Flags: needinfo?(ttromey)
https://hg.mozilla.org/mozilla-central/rev/26fca47bf8db
Status: ASSIGNED → RESOLVED
Closed: 9 years ago
status-firefox49: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 49
Product: Firefox → DevTools
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: