1268991 - "Cancel" button in "Finish Review" modal isn't necessary

Status: RESOLVED INVALID

(MozReview Graveyard :: Review Board: User Interface, defect)

Description

[David Walsh :davidwalsh]

The "OK" and "Cancel" buttons in the "Review For..." dialog aren't necessary; if someone doesn't have comments, they should simply leave the dialog empty and the server side should discard the empty text.

Comment 1

[Mark Côté [:mcote]]

The "cancel" button, at least, removes the comment--but yeah, it does seem unnecessary when one can just select all & delete.

Comment 2

[Steven MacLeod [:smacleod]]

(In reply to Mark Côté [:mcote] from comment #1)
> The "cancel" button, at least, removes the comment--but yeah, it does seem
> unnecessary when one can just select all & delete.

The cancel button will revert any changes you've made to the comment, it does not remove it.

e.g. Add text "Hello" -> click OK -> Edit comment -> change to "Goodbye" -> click Cancel -> text is reverted to "Hello".

Comment 3

[Mark Côté [:mcote]]

Yes, sorry, that's what I meant.  But yeah, I guess that's slightly useful.

Comment 4

[David Walsh :davidwalsh]

My mistake, closing as INVALID.