"Cancel" button in "Finish Review" modal isn't necessary

RESOLVED INVALID

Status

RESOLVED INVALID
3 years ago
3 years ago

People

(Reporter: davidwalsh, Unassigned)

Tracking

Details

(Reporter)

Description

3 years ago
The "OK" and "Cancel" buttons in the "Review For..." dialog aren't necessary; if someone doesn't have comments, they should simply leave the dialog empty and the server side should discard the empty text.
The "cancel" button, at least, removes the comment--but yeah, it does seem unnecessary when one can just select all & delete.
(In reply to Mark Côté [:mcote] from comment #1)
> The "cancel" button, at least, removes the comment--but yeah, it does seem
> unnecessary when one can just select all & delete.

The cancel button will revert any changes you've made to the comment, it does not remove it.

e.g. Add text "Hello" -> click OK -> Edit comment -> change to "Goodbye" -> click Cancel -> text is reverted to "Hello".
Yes, sorry, that's what I meant.  But yeah, I guess that's slightly useful.
(Reporter)

Comment 4

3 years ago
My mistake, closing as INVALID.
Status: NEW → RESOLVED
Last Resolved: 3 years ago
Resolution: --- → INVALID
You need to log in before you can comment on or make changes to this bug.