Add empty state for no synced devices

RESOLVED FIXED in Firefox 48

Status

()

Firefox for Android
General
RESOLVED FIXED
2 years ago
2 years ago

People

(Reporter: liuche, Assigned: liuche)

Tracking

({regression})

Trunk
Firefox 49
ARM
Android
regression
Points:
---

Firefox Tracking Flags

(firefox48+ verified, firefox49 verified)

Details

Attachments

(4 attachments)

Created attachment 8747319 [details]
Screenshot: Empty state for sync

Add a hacky version of "Sync Setup" to empty history-sync panel.

Attaching a screenshot for a WIP patch for sync empty state. This has some edge cases in landscape mode, or on small phones.
Created attachment 8747387 [details] [diff] [review]
Patch: Empty state

This is built on top of the commits from bug 1261527 but reviewboard doesn't allow pushing from commit series with more than one bug number.
Assignee: nobody → liuche
Attachment #8747387 - Flags: review?(s.kaspari)
Barbara, if we want to get the empty state work into 48, we can uplift the patches from this bug and the bug it's built upon (bug 1261527).
Flags: needinfo?(bbermes)
This is a hacky patch to get the empty states to appear underneath the RecyclerView that uses weights because the RecyclerView library in 23.0 doesn't handle wrap_content.

When using ViewStubs, I was running into a lot of trouble with the inflated views disappearing during device rotation so I just dropped them and replaced them with normal views. I could also turn them into <merge> views, if that's better?

I'm still not sure what was going on with the view stubs, but I did some debugging inside of onLayout and the RecyclerView just expanded to fill all the space. Perhaps the layout dropped the views that replaced the viewstubs because they weren't kept track of in the main layout for some reason?
Sounds good Chenxia and thanks for finding a way to include this.
Flags: needinfo?(bbermes)
Attachment #8747387 - Flags: review?(s.kaspari) → review+

Comment 5

2 years ago
(In reply to Chenxia Liu [:liuche] from comment #1)
> Created attachment 8747387 [details] [diff] [review]
> Patch: Empty state
> 
> This is built on top of the commits from bug 1261527 but reviewboard doesn't
> allow pushing from commit series with more than one bug number.

I think you can do this with "hg push -c <rev> review".

Comment 7

2 years ago
bugherder
https://hg.mozilla.org/mozilla-central/rev/f410732bf7cf
Status: NEW → RESOLVED
Last Resolved: 2 years ago
status-firefox49: affected → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 49
Comment on attachment 8747387 [details] [diff] [review]
Patch: Empty state

Approval Request Comment
[Feature/regressing bug #]: Sync empty state was removed in bug 1220928.
[User impact if declined]: No entry point into sync setup
[Describe test coverage new/current, TreeHerder]: Local, nightly
[Risks and why]: low, reuses sync empty state from previous version
[String/UUID change made/needed]: none

Depends on bug 1261527.
Attachment #8747387 - Flags: approval-mozilla-aurora?
Comment on attachment 8747387 [details] [diff] [review]
Patch: Empty state

Fix for regression from 48.
Attachment #8747387 - Flags: approval-mozilla-aurora? → approval-mozilla-aurora+
status-firefox48: --- → affected
tracking-firefox48: --- → +
Keywords: regression
Created attachment 8749076 [details]
Screenshot_2016-05-05-10-55-28.png

Verified as fixed using:
Device: Moto X (Android 4.4)
Build: Firefox for Android 49.0a1 (2016-05-04)
status-firefox49: fixed → verified
This patch doesn't apply to aurora.

$ hg graft -er f410732bf7cf
grafting 341185:f410732bf7cf "Bug 1269027 - Add empty state for no synced devices. r=sebastian"
merging mobile/android/base/java/org/mozilla/gecko/home/CombinedHistoryAdapter.java
merging mobile/android/base/java/org/mozilla/gecko/home/CombinedHistoryPanel.java
merging mobile/android/base/resources/layout/home_combined_history_panel.xml
warning: conflicts while merging mobile/android/base/java/org/mozilla/gecko/home/CombinedHistoryAdapter.java! (edit, then use 'hg resolve --mark')
warning: conflicts while merging mobile/android/base/java/org/mozilla/gecko/home/CombinedHistoryPanel.java! (edit, then use 'hg resolve --mark')
warning: conflicts while merging mobile/android/base/resources/layout/home_combined_history_panel.xml! (edit, then use 'hg resolve --mark')
abort: unresolved conflicts, can't continue
(use hg resolve and hg graft --continue)
Flags: needinfo?(liuche)
Wes, this bug depends on bug 1261527, so that needs to be uplifted first. I requested approval, so we should wait on that. Is there a releng way I should message that? I added it to the aurora request comment, and also added in the bug dependency, but let me know if there is better way I can flag this for releng?
Flags: needinfo?(liuche) → needinfo?(wkocher)
https://hg.mozilla.org/releases/mozilla-aurora/rev/b14d8e23323e
status-firefox48: affected → fixed
Flags: needinfo?(wkocher)
Created attachment 8755429 [details]
Screenshot_20160523-161039.png

Verified as fixed using:
Device: Motorola Nexus 6 (Android 6.0)
Build: Firefox for Android 48.0a2 (2016-05-23)
status-firefox48: fixed → verified
You need to log in before you can comment on or make changes to this bug.