With e10s on OS X, mousewheel.default.delta_multiplier_x y z have no effect on trackpad scrolling

RESOLVED FIXED in Firefox 48

Status

()

Core
Panning and Zooming
P2
normal
RESOLVED FIXED
2 years ago
2 years ago

People

(Reporter: alessandro, Assigned: kats)

Tracking

({regression})

49 Branch
mozilla49
Unspecified
Mac OS X
regression
Points:
---

Firefox Tracking Flags

(e10s+, firefox47 wontfix, firefox48 fixed, firefox49 fixed)

Details

(Whiteboard: [gfx-noted])

MozReview Requests

()

Submitter Diff Changes Open Issues Last Updated
Loading...
Error loading review requests:

Attachments

(1 attachment)

(Reporter)

Description

2 years ago
User Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.11; rv:49.0) Gecko/20100101 Firefox/49.0
Build ID: 20160429030215

Steps to reproduce:

one feature i really like in firefox is the possibility of increase scrooling speed  by modifying mousewheel.default.delta_multiplier_x /y/z value,but unluckily enabling es 10 those value are not working anymore,any fix possible?

Updated

2 years ago
tracking-e10s: --- → ?
Component: Untriaged → Panning and Zooming
Product: Firefox → Core
Looks like we're not applying the multipliers to the pan events, although the main thread code does.
Status: UNCONFIRMED → NEW
status-firefox47: --- → affected
status-firefox48: --- → affected
status-firefox49: --- → affected
Ever confirmed: true
Keywords: regression
OS: Unspecified → Mac OS X
Summary: enabling es 10 in latest nightly 49 and osx mousewheel.default.delta_multiplier_x y z have no effect → With e10s on OS X, mousewheel.default.delta_multiplier_x y z have no effect on trackpad scrolling
Whiteboard: [gfx-noted]
We do this for wheel events at [1]. It shouldn't be too hard to hook up for the pan events, assuming it makes sense to do so. The prefs are explicitly called mousewheel prefs so I'm not sure if it actually makes sense to do.

[1] http://mxr.mozilla.org/mozilla-central/source/gfx/layers/apz/src/APZCTreeManager.cpp?rev=c6884584fa07#1124
I think it makes to do so. The distinction between touchpad scroll events and the term "wheel" is really fuzzy anyway, and I don't see a good reason why APZ should change existing behavior in this case.
Assignee: nobody → bugmail.mozilla
status-firefox47: affected → wontfix
Created attachment 8748142 [details]
MozReview Request: Bug 1269032 - Add support for user multipliers to pan gesture inputs. r?mstange

Review commit: https://reviewboard.mozilla.org/r/50169/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/50169/
Attachment #8748142 - Flags: review?(mstange)
Comment on attachment 8748142 [details]
MozReview Request: Bug 1269032 - Add support for user multipliers to pan gesture inputs. r?mstange

https://reviewboard.mozilla.org/r/50169/#review47023
Attachment #8748142 - Flags: review?(mstange) → review+

Updated

2 years ago
tracking-e10s: ? → +
Priority: -- → P2

Comment 8

2 years ago
bugherder
https://hg.mozilla.org/mozilla-central/rev/f15a963b5d4e
Status: NEW → RESOLVED
Last Resolved: 2 years ago
status-firefox49: affected → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla49
Comment on attachment 8748142 [details]
MozReview Request: Bug 1269032 - Add support for user multipliers to pan gesture inputs. r?mstange

Approval Request Comment
[Feature/regressing bug #]: APZ
[User impact if declined]: the mousewheel.default.delta_multiplier_x /y/z modifiers are not respected with trackpad scrolling with APZ enabled
[Describe test coverage new/current, TreeHerder]: tested locally. Hard to write automated tests for this though because we don't yet have APIs to simulate trackpad scrolling properly.
[Risks and why]: low risk, applies pre-existing tested code to trackpad scrolling codepaths
[String/UUID change made/needed]: none
Attachment #8748142 - Flags: approval-mozilla-aurora?
Comment on attachment 8748142 [details]
MozReview Request: Bug 1269032 - Add support for user multipliers to pan gesture inputs. r?mstange

Trackpad scroll fix, ok on m-c for a week, let's uplift to aurora.
Attachment #8748142 - Flags: approval-mozilla-aurora? → approval-mozilla-aurora+

Comment 11

2 years ago
bugherderuplift
https://hg.mozilla.org/releases/mozilla-aurora/rev/f984610b6861
status-firefox48: affected → fixed
You need to log in before you can comment on or make changes to this bug.