Closed
Bug 1269032
Opened 8 years ago
Closed 8 years ago
With e10s on OS X, mousewheel.default.delta_multiplier_x y z have no effect on trackpad scrolling
Categories
(Core :: Panning and Zooming, defect, P2)
Tracking
()
RESOLVED
FIXED
mozilla49
People
(Reporter: ale160382, Assigned: kats)
Details
(Keywords: regression, Whiteboard: [gfx-noted])
Attachments
(1 file)
58 bytes,
text/x-review-board-request
|
mstange
:
review+
lizzard
:
approval-mozilla-aurora+
|
Details |
User Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.11; rv:49.0) Gecko/20100101 Firefox/49.0 Build ID: 20160429030215 Steps to reproduce: one feature i really like in firefox is the possibility of increase scrooling speed by modifying mousewheel.default.delta_multiplier_x /y/z value,but unluckily enabling es 10 those value are not working anymore,any fix possible?
Updated•8 years ago
|
Assignee | ||
Comment 1•8 years ago
|
||
Looks like we're not applying the multipliers to the pan events, although the main thread code does.
Status: UNCONFIRMED → NEW
status-firefox47:
--- → affected
status-firefox48:
--- → affected
status-firefox49:
--- → affected
Ever confirmed: true
Keywords: regression
OS: Unspecified → Mac OS X
Summary: enabling es 10 in latest nightly 49 and osx mousewheel.default.delta_multiplier_x y z have no effect → With e10s on OS X, mousewheel.default.delta_multiplier_x y z have no effect on trackpad scrolling
Whiteboard: [gfx-noted]
Assignee | ||
Comment 2•8 years ago
|
||
We do this for wheel events at [1]. It shouldn't be too hard to hook up for the pan events, assuming it makes sense to do so. The prefs are explicitly called mousewheel prefs so I'm not sure if it actually makes sense to do. [1] http://mxr.mozilla.org/mozilla-central/source/gfx/layers/apz/src/APZCTreeManager.cpp?rev=c6884584fa07#1124
Comment 3•8 years ago
|
||
I think it makes to do so. The distinction between touchpad scroll events and the term "wheel" is really fuzzy anyway, and I don't see a good reason why APZ should change existing behavior in this case.
Assignee | ||
Updated•8 years ago
|
Assignee: nobody → bugmail.mozilla
Assignee | ||
Updated•8 years ago
|
Assignee | ||
Comment 4•8 years ago
|
||
https://treeherder.mozilla.org/#/jobs?repo=try&revision=e26c8fb142d4
Assignee | ||
Comment 5•8 years ago
|
||
Review commit: https://reviewboard.mozilla.org/r/50169/diff/#index_header See other reviews: https://reviewboard.mozilla.org/r/50169/
Attachment #8748142 -
Flags: review?(mstange)
Comment 6•8 years ago
|
||
Comment on attachment 8748142 [details] MozReview Request: Bug 1269032 - Add support for user multipliers to pan gesture inputs. r?mstange https://reviewboard.mozilla.org/r/50169/#review47023
Attachment #8748142 -
Flags: review?(mstange) → review+
Updated•8 years ago
|
Priority: -- → P2
Comment 8•8 years ago
|
||
bugherder |
https://hg.mozilla.org/mozilla-central/rev/f15a963b5d4e
Status: NEW → RESOLVED
Closed: 8 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla49
Assignee | ||
Comment 9•8 years ago
|
||
Comment on attachment 8748142 [details] MozReview Request: Bug 1269032 - Add support for user multipliers to pan gesture inputs. r?mstange Approval Request Comment [Feature/regressing bug #]: APZ [User impact if declined]: the mousewheel.default.delta_multiplier_x /y/z modifiers are not respected with trackpad scrolling with APZ enabled [Describe test coverage new/current, TreeHerder]: tested locally. Hard to write automated tests for this though because we don't yet have APIs to simulate trackpad scrolling properly. [Risks and why]: low risk, applies pre-existing tested code to trackpad scrolling codepaths [String/UUID change made/needed]: none
Attachment #8748142 -
Flags: approval-mozilla-aurora?
Comment 10•8 years ago
|
||
Comment on attachment 8748142 [details] MozReview Request: Bug 1269032 - Add support for user multipliers to pan gesture inputs. r?mstange Trackpad scroll fix, ok on m-c for a week, let's uplift to aurora.
Attachment #8748142 -
Flags: approval-mozilla-aurora? → approval-mozilla-aurora+
Comment 11•8 years ago
|
||
bugherder uplift |
https://hg.mozilla.org/releases/mozilla-aurora/rev/f984610b6861
You need to log in
before you can comment on or make changes to this bug.
Description
•