1269048 - Crash in MediaDecoder if metadata didn't complete.

Status: RESOLVED FIXED

(Core :: Audio/Video: Playback, defect)

Description

[Jean-Yves Avenard [:jya]]

like https://treeherder.mozilla.org/logviewer.html#?job_id=20156057&repo=try

 09:34:14  WARNING -  PROCESS-CRASH | dom/media/mediasource/test/test_WaitingOnMissingData_mp4.html | application crashed [@ mozilla::MediaDecoder::DumpDebugInfo()]
 09:34:14     INFO -  Crash dump filename: c:\users\cltbld~1.t-w\appdata\local\temp\tmp8ouk68.mozrunner\minidumps\1dbe9c40-fb4a-4be5-955d-cb914b1d50cb.dmp
 09:34:14     INFO -  Operating system: Windows NT
 09:34:14     INFO -                    6.2.9200
 09:34:14     INFO -  CPU: amd64
 09:34:14     INFO -       family 6 model 30 stepping 5
 09:34:14     INFO -       8 CPUs
 09:34:14     INFO -  Crash reason:  EXCEPTION_ACCESS_VIOLATION_READ
 09:34:14     INFO -  Crash address: 0x0
 09:34:14     INFO -  Process uptime: 343 seconds
 09:34:14     INFO -  Thread 0 (crashed)
 09:34:14     INFO -   0  xul.dll!mozilla::MediaDecoder::DumpDebugInfo() [MediaDecoder.cpp:7f3428ad82ae : 1882 + 0x7]
 09:34:14     INFO -      rax = 0x00007fd8c22d17c4   rdx = 0x00000055538ebaa0
 09:34:14     INFO -      rcx = 0x0000000000000000   rbx = 0x00000055538eba80
 09:34:14     INFO -      rsi = 0x00000055625da240   rdi = 0x000000557118cc00
 09:34:14     INFO -      rbp = 0x00000055538eb999   rsp = 0x00000055538eb8d0
 09:34:14     INFO -       r8 = 0x000000557988c800    r9 = 0x00000055538eba80
 09:34:14     INFO -      r10 = 0x00000055625da240   r11 = 0x00000055625da240
 09:34:14     INFO -      r12 = 0x000000557144e460   r13 = 0x0000000000000004
 09:34:14     INFO -      r14 = 0x00000000000000ee   r15 = 0x000007fd679ef360
 09:34:14     INFO -      rip = 0x000007fd66170bb2

null deref, likely because mInfo is null

Comment 1

[Jean-Yves Avenard [:jya]]

Attachment: MozReview Request: Bug 1269048: Prevent null deref in debugging information. r?jwwang

Review commit: https://reviewboard.mozilla.org/r/49929/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/49929/

Comment 2

[JW Wang [:jwwang] [:jw_wang]]

Comment on attachment 8747557 [details]
MozReview Request: Bug 1269048: Prevent null deref in debugging information. r?jwwang

https://reviewboard.mozilla.org/r/49929/#review46647

Comment 3

[Pulsebot]

https://hg.mozilla.org/integration/mozilla-inbound/rev/a34db9cb5280

Comment 4

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/a34db9cb5280