1269114 - [x86_64] Last picked directory not saved when using Flash Player uploader

Status: RESOLVED FIXED

(Core Graveyard :: Plug-ins, defect, P3)

Description

[Loic]

Reported here: https://forums.mozfr.org/viewtopic.php?f=5&t=129289

STR: only with Firefox 64bits.
1) Open http://www.tinywebgallery.com/en/tfu/web_demo1.php
2) Click on the button "Add files"
NB: by default, "My Documents" is open in the dialog box
3) Go to a different folder like "My Images" and select a picture
4) Click again on "Add files" to add a 2nd picture

Result: "My Documents" is open instead of "My Images"
In addition, if you repeat step #4, you have to click twice on "Add files" to call the dialog box.

Regression range:
https://hg.mozilla.org/integration/mozilla-inbound/pushloghtml?fromchange=47cefafd3a2abdfdd1736a3b49239ddd4eb8593b&tochange=a01862fb4e30498452a496daee9e15da8c488c99

Bug 1201904 - [x86_64][Win] IME is disabled on Flash Player

Comment 1

[Makoto Kato [:m_kato]]

(In reply to Loic from comment #0)
> Reported here: https://forums.mozfr.org/viewtopic.php?f=5&t=129289
> 
> STR: only with Firefox 64bits.
> 1) Open http://www.tinywebgallery.com/en/tfu/web_demo1.php
> 2) Click on the button "Add files"
> NB: by default, "My Documents" is open in the dialog box
> 3) Go to a different folder like "My Images" and select a picture
> 4) Click again on "Add files" to add a 2nd picture
> 
> Result: "My Documents" is open instead of "My Images"
> In addition, if you repeat step #4, you have to click twice on "Add files"
> to call the dialog box.
> 
> Regression range:
> https://hg.mozilla.org/integration/mozilla-inbound/
> pushloghtml?fromchange=47cefafd3a2abdfdd1736a3b49239ddd4eb8593b&tochange=a018
> 62fb4e30498452a496daee9e15da8c488c99
> 
> Bug 1201904 - [x86_64][Win] IME is disabled on Flash Player

I think that this depends on plugin sandbox instead.  Before my landing, user cannot open dialog by step 2.

Comment 2

[Makoto Kato [:m_kato]]

And

Comment 3

[Makoto Kato [:m_kato]]

Bug 1201904 was landed at Firefox 47, but this occurred on 46.

Comment 4

[Loic]

Indeed, it's a regression after enabling NPAPI sandboxing for FF 64 bits.

I still see 3 issues with http://www.tinywebgallery.com/en/tfu/web_demo1.php
1) last picked folder is not saved
2) sometimes the user needs to click twice on the button to call the dialog box to select a file
3) the dialog box has the "old" Windows style, not the case with FF 32b: http://i.imgur.com/EzTqC5w.jpg

Comment 5

[Liz Henry (:lizzard) (relman/hg->git project)]

Too late for 46.  Why is 47 unaffected, but 46 and 48/49 are affected? Is that true?
Tracking since this is a regression, even if it is from 43 it would be nice to fix.

Comment 6

[Benjamin Smedberg]

This is not going to be urgently fixed. It's a win64-only issue and Flash filepickers are becoming rapidly rarer. I suggest that tracking this is not valuable.

Comment 7

[Marcia Knous [:marcia]]

Won't fix for 48 and untracking for 49.

Comment 8

[mirh]

Probably has the same cause of bug 1284897.

Comment 9

[Liz Henry (:lizzard) (relman/hg->git project)]

Too late for beta, while we can still take a fix in nightly, this is now set to p3 so platform triage will no longer cover it.

Comment 10

[Chris Peterson [:cpeterson]]

In today's sandboxing meeting, David said he was working on this bug.

Comment 11

[David Parks [:handyman]]

Attachment: regkeys.patch (r+ed by jimm)

This patch addresses the bug as it was reported in comment 0.  There is additional information reported in comment 4.

The problem with the last picked folder was due to registry keys not being available.  There are a few keys under "HKEY_CURRENT_USER\\Software\\Microsoft\\Windows\\CurrentVersion\\Explorer" that we might want but this patch is limited to exposing the least amount needed.

(The issue with needing to push "Add Files" twice seems to be plugin related but is also fixed with this patch.)

Comment 4 adds that the old style of file picker window is used.  Running Win10, however, I see the same behavior on x64 with sandbox as I do on x64 without... and the same as on x86 as well.  Maybe that happens on Win7 only?

Tests:
https://treeherder.mozilla.org/#/jobs?repo=try&revision=8b2b59ac953a

Comment 12

[mirh]

As I said in bug 1284897 comment 8, this kind of issues only happens when there's no pluginreg.dat in settings folder. 

Make sure you aren't testing this on the first run of a fresh environment. 
I can confirm it does happen in W10.

Comment 13

[Jim Mathies [:jimm]]

Comment on attachment 8794935 [details] [diff] [review]
regkeys.patch (r+ed by jimm)

Review of attachment 8794935 [details] [diff] [review]:
-----------------------------------------------------------------

I guess we open up a small potential for a privacy leak here, if the content process is compromised we give it access to recently used file lists.. not a major issue AFAICT.

Comment 14

[David Parks [:handyman]]

(In reply to mirh from comment #12)
> As I said in bug 1284897 comment 8, this kind of issues only happens when
> there's no pluginreg.dat in settings folder. 
> 
> Make sure you aren't testing this on the first run of a fresh environment. 
> I can confirm it does happen in W10.

(NI only so mirh sees this.)

We're going to land this fix to the "last picked directory" bug initially reported.  When that happens, if you still see the "dialog box is old style" bug, feel free to open a new bug to that effect.  We want to keep them separate in any event -- losing the last picked directory is a much bigger deal.

Comment 15

[David Parks [:handyman]]

r+ in comment 13
tests in comment 11

Comment 16

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/72904b99af24
[x86_64] Last picked directory not saved when using Flash Player uploader. r=jimm

Comment 17

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/72904b99af24