1269129 - Hide the toolbar when dimming system UI in reader view

Status: RESOLVED INVALID

(Firefox for Android Graveyard :: Reader View, defect)

Description

[:Margaret Leibovic]

Right now we have logic to dim the system UI when scrolling down in reader view, but the toolbar won't hide until you do a substantial scroll. We should just animate the toolbar off screen when we dim the system UI.

The logic you'll need to change is in here:
http://hg.mozilla.org/mozilla-central/annotate/1461a4071341/mobile/android/base/java/org/mozilla/gecko/GeckoApp.java#l2731

Comment 1

[Cesar Valiente]

Hi guys, 

if nobody is working on this one, I can work on it :-)

Comment 2

[:Margaret Leibovic]

(In reply to Cesar Valiente from comment #1)
> Hi guys, 
> 
> if nobody is working on this one, I can work on it :-)

Go for it! Feel free to join #mobile on irc.mozilla.org to ask questions if you need help figuring things out.

This is not a [good first bug], so I expect you have a development environment already set up.

Comment 3

[Cesar Valiente]

Hi Margaret,

yes, I already have the development environment already set up, so I will invest time on this bug :-)

Is there any paper/doc/slides where we can understand better the architecture of the app? 
I checked out last week your slides located in --> http://margaretleibovic.com/talks/fennec-native-101.html but there are not longer available (or at least, right now are not loaded). 
I'm going to watch the video of your talk: https://www.youtube.com/watch?v=yRI38CIYXDo as soon as I'm at home, but I was wondering if the team had more concrete info about that.

Anyways, I will ask you and the rest of the team in #mobile channel for sure :-D

Thanks.

Comment 4

[:Margaret Leibovic]

(In reply to Cesar Valiente from comment #3)
> Hi Margaret,
> 
> yes, I already have the development environment already set up, so I will
> invest time on this bug :-)
> 
> Is there any paper/doc/slides where we can understand better the
> architecture of the app? 
> I checked out last week your slides located in -->
> http://margaretleibovic.com/talks/fennec-native-101.html but there are not
> longer available (or at least, right now are not loaded). 
> I'm going to watch the video of your talk:
> https://www.youtube.com/watch?v=yRI38CIYXDo as soon as I'm at home, but I
> was wondering if the team had more concrete info about that.

This is really outdated, I wouldn't trust it at this point.

Unfortunately, no, we don't have any overview architecture docs, but for this bug you can just stay focused on the logic around the area I linked to. The best way to learn is to just try modifying things and see what happens.

Comment 5

[Cesar Valiente]

Thanks Margaret.

I was just wondering about this info, since it would be good to have a big picture about how Firefox for Android is built.

But I will continue as you say.

Comment 6

[Gautam Prajapati]

Hello, Margaret, I would like to work on this bug.

Comment 7

[Gautam Prajapati]

(In reply to Gautam Prajapati from comment #6)
> Hello, Margaret, I would like to work on this bug.

I'm not able to reproduce this bug, in my case the toolbar goes out as soon as I start scrolling down. Anything I'm missing?

Comment 8

[Kevin Brosnan [Ex-Mozilla]]

This is not a valid bug any more with the redesign.