1269194 - Make CheckerboardReportService accessible also outside of about:checkerboard

Status: RESOLVED FIXED

(Core :: Panning and Zooming, defect)

Description

[Avi Halachmi (:avih)]

Currently the CheckerboardReportService API is blocked except if accessed from about:checkerboard.

I think it's OK that it requires privileged access (even though there's nothing secretive about it) but otherwise should not limit access to other Gecko code IMO.

The use case I have in mind right now is a talos APZ scroll test, but I still think it should be accessible to Gecko code in general.

Comment 1

[Kartikaya Gupta (email:[e-mail])]

ehsan, we added this CheckerboardReportService API back in bug 1238042 and exposed it to about:checkerboard (which we kept unprivileged) explicitly via the check at [1]. Do you have any concerns about relaxing the URL check and allowing any privileged code to access it? I agree with avi that there isn't really anything secretive about it.

[1] http://mxr.mozilla.org/mozilla-central/source/gfx/layers/apz/util/CheckerboardReportService.cpp?rev=77d65c5c2422&mark=136-136#129

Comment 2

[(no longer active)]

Allowing privileged code access here seems fine to me!

Comment 3

[Kartikaya Gupta (email:[e-mail])]

Attachment: Patch

Does this work for you? I tested both e10s and non-e10s to verify that it is accessible in about:checkerboard and other chrome pages (like about:about) but is NOT accessible in web content or unprivileged pages like about:blank.

Comment 4

[Avi Halachmi (:avih)]

Comment on attachment 8749745 [details] [diff] [review]
Patch

Review of attachment 8749745 [details] [diff] [review]:
-----------------------------------------------------------------

Confirmed works for me. Thanks.

Comment 5

[Pulsebot]

https://hg.mozilla.org/integration/mozilla-inbound/rev/d9bbd4950bc0

Comment 6

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/d9bbd4950bc0