Closed Bug 1269203 Opened 4 years ago Closed 4 years ago

Port bug 1122642 - [h2] better error state for INADEQUATE_SECURITY

Categories

(Thunderbird :: General, defect)

defect
Not set

Tracking

(thunderbird48 affected, thunderbird49 fixed)

RESOLVED FIXED
Thunderbird 49.0
Tracking Status
thunderbird48 --- affected
thunderbird49 --- fixed

People

(Reporter: aryx, Assigned: aryx)

References

Details

Attachments

(1 file)

No description provided.
Attached patch patch, v1Splinter Review
Attachment #8747534 - Flags: review?(mkmelin+mozilla)
Comment on attachment 8747534 [details] [diff] [review]
patch, v1

Review of attachment 8747534 [details] [diff] [review]:
-----------------------------------------------------------------

I can see error about this missing entity when starting up TB offline on a folder that is empty. Then a message about offline mode appears in the message preview pane. That was missing the entity even though it is not displaying it in my case.

The text seems to be copied from Firefox.
Attachment #8747534 - Flags: review?(mkmelin+mozilla) → review+
You might want to try applying Bug 653386 (Consider overriding netErrorApp.dtd rather than netError.dtd) This will allow you to inherit strings from the Gecko netError.dtd while using netErrorApp.dtd to override only the strings you want to modify.
Comment on attachment 8747534 [details] [diff] [review]
patch, v1

[Approval Request Comment]
Regression caused by (bug #): bug 1269203
User impact if declined: Yellow error message in message pane under some circumstances (e.g. if user starts Thunderbird offline or there is a connection issue)
Testing completed (on c-c, etc.): Verified fixed in latest Daily
Risk to taking this patch (and alternatives if risky): -
Attachment #8747534 - Flags: approval-comm-aurora?
You never set a Target Milestone, so my query didn't see approval-comm-aurora?
Target Milestone: --- → Thunderbird 49.0
Comment on attachment 8747534 [details] [diff] [review]
patch, v1

Too late now.
Attachment #8747534 - Flags: approval-comm-aurora?
You need to log in before you can comment on or make changes to this bug.