Closed
Bug 1269279
Opened 8 years ago
Closed 8 years ago
Remove SEC_NORMAL from toolkit/components/passwordmgr/
Categories
(Core :: DOM: Security, defect)
Core
DOM: Security
Tracking
()
RESOLVED
FIXED
mozilla49
Tracking | Status | |
---|---|---|
firefox49 | --- | fixed |
People
(Reporter: ckerschb, Assigned: ckerschb)
References
Details
(Whiteboard: [domsecurity-active])
Attachments
(1 file, 1 obsolete file)
4.90 KB,
patch
|
sicking
:
review+
|
Details | Diff | Splinter Review |
No description provided.
Assignee | ||
Updated•8 years ago
|
Assignee | ||
Comment 1•8 years ago
|
||
Hey Bill, since you already reviewed Bug 1138649 I thought you might be able to review those test updates as well. Ideally we would also use NetUtil.newChannel() for test_prompt_async.html but I suppose there is not an easy way to include NetUtil.jsm within that test, right? NetUtil.newChannel() would use SEC_ALLOW_CROSS_ORIGIN_DATA_IS_NULL when loaded using a systemPrincipal [1], so we should also use SEC_ALLOW_CROSS_ORIGIN_DATA_IS_NULL within that test in case we can't update to using NetUtil.newChannel(). [1] http://mxr.mozilla.org/mozilla-central/source/netwerk/base/NetUtil.jsm#388
Attachment #8747626 -
Flags: review?(wmccloskey)
You can use NetUtil.jsm by importing it through SpecialPowers.Cu.import. Here's an example: http://searchfox.org/mozilla-central/source/dom/browser-element/mochitest/browserElement_AudioPlayback.js#7 To be honest, though, I don't understand what these flags means, so I'm not sure I should review this.
Attachment #8747626 -
Flags: review?(wmccloskey)
Assignee | ||
Comment 3•8 years ago
|
||
(In reply to Bill McCloskey (:billm) from comment #2) > You can use NetUtil.jsm by importing it through SpecialPowers.Cu.import. > Here's an example: > http://searchfox.org/mozilla-central/source/dom/browser-element/mochitest/ > browserElement_AudioPlayback.js#7 Ah, thanks for the info. I suppose then I have to ask Jonas for this one as well - thanks!
Assignee | ||
Updated•8 years ago
|
Attachment #8747626 -
Flags: review?(jonas)
Comment on attachment 8747626 [details] [diff] [review] bug_1269279_remove_sec_normal_toolkit_components_passwordmgr.patch Review of attachment 8747626 [details] [diff] [review]: ----------------------------------------------------------------- Why not use NetUtil.newChannel?
Attachment #8747626 -
Flags: review?(jonas)
Assignee | ||
Comment 5•8 years ago
|
||
(In reply to Jonas Sicking (:sicking) from comment #4) > Why not use NetUtil.newChannel? Bill just told me that I can use SpecialPowers to import NetUtil, hence why - works now!
Attachment #8747626 -
Attachment is obsolete: true
Attachment #8749639 -
Flags: review?(jonas)
Attachment #8749639 -
Flags: review?(jonas) → review+
Comment 7•8 years ago
|
||
bugherder |
https://hg.mozilla.org/mozilla-central/rev/e9e6486b0d39
Status: ASSIGNED → RESOLVED
Closed: 8 years ago
status-firefox49:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla49
You need to log in
before you can comment on or make changes to this bug.
Description
•