1269316 - Port bug 1193762 to Mailnews (bustage fix)

Status: RESOLVED FIXED

(MailNews Core :: Database, defect)

Description

[Jorg K (CEST = GMT+2)]

Now that bug 1193762 has landed, we have fresh bustage, for example:

c:/builds/moz2_slave/tb-c-cen-w32-ntly-000000000000/build/mailnews/db/msgdb/src/nsMsgDatabase.cpp(4765): error C2662: 'nsCOMPtr<nsIMsgThread>::operator T(void) const &&': cannot convert 'this' pointer from 'nsCOMPtr<nsIMsgThread>' to 'const nsCOMPtr<nsIMsgThread> &&'

/builds/slave/tb-c-cen-m64-ntly-000000000000/build/mailnews/db/msgdb/src/nsMsgDatabase.cpp:4764:17: error: conversion function from 'nsCOMPtr<nsIMsgThread>' to 'nsIMsgThread *'

Comment 1

[:aceman]

It is not yet visible on trunk/try. How many occurrences are there?
And what is the pattern to convert there cases?

Comment 2

[Frank-Rainer Grahl (:frg)]

Attachment: 1269316-WIP.patch

Just tried to compile suite and stumbled over this. 

Fix for first three errors. Got the next one in ldap. 

My c++ knowledge is limited. Fix might be rubbish.

Comment 3

[aleth [:aleth]]

(In reply to Frank-Rainer Grahl from comment #2)
> Created attachment 8747670 [details] [diff] [review]
> 1269316-WIP.patch
> 
> Just tried to compile suite and stumbled over this. 
> 
> Fix for first three errors. Got the next one in ldap. 
> 
> My c++ knowledge is limited. Fix might be rubbish.

I'm sure you could f?aryeh if you have a patch.

Comment 4

[Frank-Rainer Grahl (:frg)]

Attachment: 1269316-c-c-nscomptr.patch

ldap blagg comparing an object to 0... Hope the is the right approach.

Seamonkey including lightning compiles and runs with this one. Only a quick test. Any other issues in TB or I could take the bug and ask for review?

Comment 5

[Jorg K (CEST = GMT+2)]

Thanks for taking this on so quickly. I'm not at my desk right now, so I can't try it in TB. I should be back in two hours to try it if no one else has done it by then.

Otherwise I'd f?:Aryeh Gregor.

Comment 6

[Jorg K (CEST = GMT+2)]

Comment on attachment 8747683 [details] [diff] [review]
1269316-c-c-nscomptr.patch

Looks good to me, I've kicked off a compile now.

Aryeh, do you have three minutes to look this over? All straight forward.

Comment 7

[Jorg K (CEST = GMT+2)]

Well, there is at least one more:
 4:13.91 c:/mozilla-source/comm-central/mailnews/imap/src/nsImapMailFolder.cpp(2237): error C2666: 'operator !=': 3 over
loads have similar conversions

nsCOMPtr<nsIMsgFolder> trashFolder;
...
NS_ASSERTION(trashFolder != 0, "couldn't find trash");

Comment 8

[Frank-Rainer Grahl (:frg)]

Hmm suite must not use this one. 

Couldn't this just be 

NS_ASSERTION(trashFolder, "couldn't find trash");

?

Seems to be a simple null pointer check but there we are with my c++ non knowledge :)

FRG

Comment 9

[Jorg K (CEST = GMT+2)]

(In reply to Frank-Rainer Grahl from comment #8)
> Couldn't this just be 
> NS_ASSERTION(trashFolder, "couldn't find trash");
Yep. I'll update the patch in a minute.

Comment 10

[Jorg K (CEST = GMT+2)]

Another one ;-)
 1:17.69 c:/mozilla-source/comm-central/calendar/base/backend/libical/calDateTime.cpp(477): error C2280: 'nsCOMPtr<calITimezone>::operator T(void) const &&': attempting to reference a deleted function

Comment 11

[Frank-Rainer Grahl (:frg)]

Didn't do a full build. Looks like I should have. Not at the desktop right now. Should be similar to one of the first ones i the patch.

Comment 12

[Jorg K (CEST = GMT+2)]

Sure. I found more. I'll keep going and attach the patch when I'm done.

Comment 13

[Jorg K (CEST = GMT+2)]

Attachment: FRG's work plus a few more hunks he missed

One review will do. All straight forward.

Comment 14

[Magnus Melin [:mkmelin]]

Comment on attachment 8747853 [details] [diff] [review]
FRG's work plus a few more hunks he missed

Review of attachment 8747853 [details] [diff] [review]:
-----------------------------------------------------------------

LGTM, r=mkmelin

::: ldap/xpcom/src/nsLDAPOperation.cpp
@@ +519,5 @@
>  {
>      nsresult rv;
>      nsresult retStatus = NS_OK;
>  
> +    if (!mMessageListener || mMsgID == 0 ) {

mind removing the space before ) too?

Comment 15

[Jorg K (CEST = GMT+2)]

Sure. I'll wait until Kent has finished building with it, then I push.

Comment 16

[Jorg K (CEST = GMT+2)]

https://hg.mozilla.org/comm-central/rev/66dea6d980f6
(Kent's build never worked, but Richard confirmed a working build.)

Comment 17

[Jorg K (CEST = GMT+2)]

Thanks a lot to Frank-Rainer Grahl! I've just added a few hunks to his patch and it got landed in his name.

Comment 18

[Philip Chee]

(In reply to Jorg K (GMT+2) from comment #17)
> Thanks a lot to Frank-Rainer Grahl! I've just added a few hunks to his patch
> and it got landed in his name.
And when Thunderbird emails your credit card information to the Russian Mafia, everyone will blame frg.

Comment 19

[Frank-Rainer Grahl (:frg)]

>> And when Thunderbird emails your credit card information to the Russian Mafia, everyone will blame frg.

Nahh. I am good friends with them. They wouldn't do this to me.

FRG (now back to serious business)