NSPR tests don't run on OS/2

RESOLVED FIXED in 4.4

Status

NSPR
NSPR
P3
normal
RESOLVED FIXED
16 years ago
14 years ago

People

(Reporter: Julien Pierre, Assigned: Wan-Teh Chang)

Tracking

Dependency tree / graph

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(2 attachments, 3 obsolete attachments)

(Reporter)

Description

16 years ago
Right now they don't even build on OS/2.
(Reporter)

Updated

16 years ago
Depends on: 119098, 126931
Priority: -- → P3
Target Milestone: --- → 4.2
(Reporter)

Updated

16 years ago
Blocks: 126923
(Reporter)

Updated

16 years ago
Depends on: 126940

Comment 1

15 years ago
Created attachment 90005 [details] [diff] [review]
get tests building

This is all that is needed - use $(LD) instead of $(LINK)
(Reporter)

Comment 2

15 years ago
Now that the tests are building, we need to run runtests.ksh .
The standard mozilla OS/2 tools don't appear to include ksh. Mike, do 
you know which one we should use ?
Also, I think runtests.ksh will need some modifications for OS/2 in 
order to pick the correct tests to run.

Comment 3

14 years ago
Created attachment 118645 [details] [diff] [review]
fix to runtests.sh

runtests.sh should be used - it needs to be modified.

You also need printf and basename from gnusutils.

Comment 4

14 years ago
Created attachment 118648 [details] [diff] [review]
Fix for sh and attach testcase

Might as well put two fixes in - attach test is totally broke for os/2
Attachment #118645 - Attachment is obsolete: true

Comment 5

14 years ago
Created attachment 118649 [details] [diff] [review]
Need direct.h for VACPP

No idea why this is working for other platforms.

tmocon.c says that #includes are needed for getcwd
(Assignee)

Comment 6

14 years ago
Michael, please update your patches against the current
NSPR client branch.
Status: NEW → ASSIGNED
Target Milestone: 4.2 → ---

Comment 7

14 years ago
Created attachment 118675 [details] [diff] [review]
Current diff

Sorry, I didn't realize some of this went in.

This puts one more OS/2 in the .sh file and fixes an include problem in
thrpool_server.c

Once these changes are in, this bug is done.
Attachment #118648 - Attachment is obsolete: true
Attachment #118649 - Attachment is obsolete: true
(Assignee)

Comment 8

14 years ago
Patch checked into the NSPR TIP and client branch.
Status: ASSIGNED → RESOLVED
Last Resolved: 14 years ago
Resolution: --- → FIXED
Whiteboard: [4.3.1]
Target Milestone: --- → 4.3
(Assignee)

Updated

14 years ago
Whiteboard: [4.3.1]
Target Milestone: 4.3 → 4.4
You need to log in before you can comment on or make changes to this bug.