If you think a bug might affect users in the 57 release, please set the correct tracking and status flags for Release Management.

make robocop honor --timeout

RESOLVED FIXED in Firefox 49

Status

Testing
General
RESOLVED FIXED
a year ago
a year ago

People

(Reporter: froydnj, Assigned: froydnj)

Tracking

unspecified
mozilla49
Points:
---

Firefox Tracking Flags

(firefox49 fixed)

Details

Attachments

(1 attachment)

(Assignee)

Description

a year ago
Our testsuites normally disable timeouts when --debugger or similar
options are specified.  Robocop doesn't do this, because apparently the
best way to debug Robocop tests is to |mach robocop [TEST-NAMES...]|,
wait for the browser window to show, and then connect a debugger.  This
setup seems suboptimal.

The setup being what it is, though, implies that runrobocop.py has no
knowledge of a debugger being connected, and therefore no idea that the
test really shouldn't time out.  Which then leads to the test going away
at that crucial moment when you are this > < close to figuring out the
bug.  Let's make runrobocop.py understand that --timeout means something
useful for such a context.
(Assignee)

Comment 1

a year ago
Created attachment 8747711 [details] [diff] [review]
make robocop honor --timeout

snorp told me the setup in comment 0 is how one debugs robocop tests, so there
might be a better way.  This patch seems helpful in any event.
Attachment #8747711 - Flags: review?(gbrown)
Attachment #8747711 - Flags: review?(gbrown) → review+

Comment 2

a year ago
https://hg.mozilla.org/integration/mozilla-inbound/rev/e8271e245c36

Comment 3

a year ago
bugherder
https://hg.mozilla.org/mozilla-central/rev/e8271e245c36
Status: NEW → RESOLVED
Last Resolved: a year ago
status-firefox49: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla49
You need to log in before you can comment on or make changes to this bug.