Port D3D11 ANGLE config to gfxConfig

RESOLVED FIXED in Firefox 49

Status

()

RESOLVED FIXED
3 years ago
3 years ago

People

(Reporter: jrmuizel, Assigned: jrmuizel)

Tracking

unspecified
mozilla49
Points:
---

Firefox Tracking Flags

(firefox49 fixed)

Details

(Whiteboard: [gfx-noted])

Attachments

(3 attachments)

(Assignee)

Updated

3 years ago
Whiteboard: [gfx-noted]
(Assignee)

Updated

3 years ago
Attachment #8747755 - Attachment is patch: true
Attachment #8747755 - Attachment mime type: text/x-patch → text/plain
(Assignee)

Comment 1

3 years ago
Created attachment 8749829 [details] [diff] [review]
Port D3D11 ANGLE to gfxConfig
Attachment #8749829 - Flags: review?(dvander)
(Assignee)

Comment 2

3 years ago
Created attachment 8749879 [details] [diff] [review]
Port D3D11 ANGLE to gfxConfig

This includes a build fix that I forgot to include in the last patch.
Attachment #8749879 - Flags: review?(dvander)
Comment on attachment 8749879 [details] [diff] [review]
Port D3D11 ANGLE to gfxConfig

Review of attachment 8749879 [details] [diff] [review]:
-----------------------------------------------------------------

::: gfx/gl/GLLibraryEGL.cpp
@@ +172,5 @@
>  
> +    FeatureState& d3d11ANGLE = gfxConfig::GetFeature(Feature::D3D11_ANGLE);
> +
> +    if (!gfxPrefs::WebGLANGLETryD3D11())
> +        d3d11ANGLE.UserDisable("User disabled D3D11 ANGLE by pref");

Just noting, this is the first thing to tie gfxConfig to a live pref, which is probably why you didn't move it to gfxWindowsPlatform? Looks like it should work though, multiple changes to the User state will just overwrite the old one.

::: gfx/thebes/gfxWindowsPlatform.cpp
@@ +2340,5 @@
>    InitializeD2D();
>  
> +  FeatureStatus compositing = gfxConfig::GetValue(Feature::D3D11_COMPOSITING);
> +  if (IsFeatureStatusFailure(compositing)) {
> +    gfxConfig::DisableByDefault(Feature::D3D11_ANGLE, compositing, "D3D11 compositing is disabled");

I'd just use gfxConfig::IsEnabled and pass FeatureStatus::Disabled (or something) instead. I changed the other instances of this pattern in the D3D9 patch already.
Attachment #8749879 - Flags: review?(dvander) → review+

Comment 5

3 years ago
bugherder
https://hg.mozilla.org/mozilla-central/rev/bde6189e0953
Status: NEW → RESOLVED
Last Resolved: 3 years ago
status-firefox49: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla49
Assignee: nobody → jmuizelaar
Depends on: 1271657
You need to log in before you can comment on or make changes to this bug.