1269387 - Port D3D11 ANGLE config to gfxConfig

Status: RESOLVED FIXED

(Core :: Graphics, defect)

Description

[Jeff Muizelaar [:jrmuizel]]

Attachment: WIP

Comment 1

[Jeff Muizelaar [:jrmuizel]]

Attachment: Port D3D11 ANGLE to gfxConfig

Comment 2

[Jeff Muizelaar [:jrmuizel]]

Attachment: Port D3D11 ANGLE to gfxConfig

This includes a build fix that I forgot to include in the last patch.

Comment 3

[David Anderson [:dvander] - inactive, e-mail if emergency]

Comment on attachment 8749879 [details] [diff] [review]
Port D3D11 ANGLE to gfxConfig

Review of attachment 8749879 [details] [diff] [review]:
-----------------------------------------------------------------

::: gfx/gl/GLLibraryEGL.cpp
@@ +172,5 @@
>  
> +    FeatureState& d3d11ANGLE = gfxConfig::GetFeature(Feature::D3D11_ANGLE);
> +
> +    if (!gfxPrefs::WebGLANGLETryD3D11())
> +        d3d11ANGLE.UserDisable("User disabled D3D11 ANGLE by pref");

Just noting, this is the first thing to tie gfxConfig to a live pref, which is probably why you didn't move it to gfxWindowsPlatform? Looks like it should work though, multiple changes to the User state will just overwrite the old one.

::: gfx/thebes/gfxWindowsPlatform.cpp
@@ +2340,5 @@
>    InitializeD2D();
>  
> +  FeatureStatus compositing = gfxConfig::GetValue(Feature::D3D11_COMPOSITING);
> +  if (IsFeatureStatusFailure(compositing)) {
> +    gfxConfig::DisableByDefault(Feature::D3D11_ANGLE, compositing, "D3D11 compositing is disabled");

I'd just use gfxConfig::IsEnabled and pass FeatureStatus::Disabled (or something) instead. I changed the other instances of this pattern in the D3D9 patch already.

Comment 4

[Pulsebot]

https://hg.mozilla.org/integration/mozilla-inbound/rev/bde6189e0953

Comment 5

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/bde6189e0953