12694 - File.remove() doesn't schedule in-use files for later deletion

Status: VERIFIED WORKSFORME

(Core Graveyard :: Installer: XPInstall Engine, defect, P3)

Description

[Sean Su]

Under win95/98, if the file is in use by a program other than seamonkey,
seamonkey's smartupdate won't be able to delete it, possibly even after a
reboot too.

This also affects Install.FileDelete().

Comment 1

[Daniel Veditz [:dveditz]]

This works well enough for the M10 release

Comment 2

[Daniel Veditz [:dveditz]]

This bug would require more special handling on Win9x to put the files to be
deleted in the WININIT.INI file.  This is the ONLY way to delete a file that is
grabbed by the OS.

Comment 3

[leger]

Bulk move of XPInstall (component to be deleted) bugs to Installer: XPInstall
Engine

Comment 4

[David Epstein]

QA believes this bug can be closed out. deleteRegisteredFile() doesn't work, but 
this is mentioned in the registry tracking bug (bug 28896). Test case 
a_delregfile covers this.

Comment 5

[Daniel Veditz [:dveditz]]

Is this bug now about File.remove()? Updating the summary to reflect what I 
think the bug is, please correct if wrong.

Comment 6

[David Epstein]

Yes, it's now about File.remove(). But it's only happening on Mac now. No 
problem deleting open files on the other platforms.

Comment 7

[Daniel Veditz [:dveditz]]

Changing obsolete milestones to nearest moral equivalent

Comment 8

[Daniel Veditz [:dveditz]]

Changing milestone for reconsideration... would hate to really really need this 
sometime in the future and not have it there

Comment 9

[Daniel Veditz [:dveditz]]

Reassigning to Don

Comment 10

[Daniel Veditz [:dveditz]]

Moz 0.9 tasks

Comment 11

[dbragg]

p3 tasks

Comment 12

[Daniel Veditz [:dveditz]]

I was looking at the code and it looks like it's calling
DeleteFileNowOrSchedule() -- that is, this might be fixed already. Please
verify, this could be an easy one :-)

Comment 13

[dbragg]

After some confusing investigation, File.remove is calling
DeleteFileNowOrSchedule.  Marking this bug as WORKSFORME since I didn't actually
fix it. 

Comment 14

[Jimmy Lee]

Build: 2001-02-21-09-Mtrunk(WIN), 2001-02-21-04-trunk(MAC)

Works for me, too.  Marking Verified!