Closed
Bug 1269444
Opened 8 years ago
Closed 8 years ago
NPAPI Browser Zoom value updates are out of order for Adobe Flash
Categories
(Core Graveyard :: Plug-ins, defect)
Core Graveyard
Plug-ins
Tracking
(firefox48 fixed, firefox49 fixed)
RESOLVED
FIXED
mozilla49
People
(Reporter: qdot, Assigned: qdot)
References
Details
Attachments
(1 file)
58 bytes,
text/x-review-board-request
|
benjamin
:
review+
Sylvestre
:
approval-mozilla-aurora+
|
Details |
When receiving browser zoom updates via the new NPNVCSSZoomValue NPAPI variable, updates are sometimes lagging behind, meaning that increasing page zoom sends back the value prior to the zoom.
Assignee | ||
Updated•8 years ago
|
Summary: NPAPI Browser Zoom value updates are out of order → NPAPI Browser Zoom value updates are out of order for Adobe Flash
Assignee | ||
Comment 1•8 years ago
|
||
Currently, CSS Zoom is updated on calls to ResolutionMayHaveChanged. However, this happens in between two calls in NPP_SetWindow, one for widget repaint and then one for resolution updates. Not having CSS Zoom updated during the first call to NPP_SetWindow would result in desynchronized window updates in Adobe Flash. Therefore, ResolutionMayHaveChanged is called on all NPP_SetWindow calls from nsPluginFrame, meaning the plugin library will always have access to the correct values via NPP_GetValue/NPP_SetValue. Review commit: https://reviewboard.mozilla.org/r/54922/diff/#index_header See other reviews: https://reviewboard.mozilla.org/r/54922/
Attachment #8756010 -
Flags: review?(benjamin)
Comment 2•8 years ago
|
||
Comment on attachment 8756010 [details] MozReview Request: Bug 1269444 - Move Plugin Zoom Value update into SetWindow call; r?bsmedberg https://reviewboard.mozilla.org/r/54922/#review51768
Attachment #8756010 -
Flags: review?(benjamin) → review+
Assignee | ||
Comment 3•8 years ago
|
||
Comment on attachment 8756010 [details] MozReview Request: Bug 1269444 - Move Plugin Zoom Value update into SetWindow call; r?bsmedberg Approval Request Comment [Feature/regressing bug #]: Bug 1171182 [User impact if declined]: CSS Zoom updates for plugins won't work right [Describe test coverage new/current, TreeHerder]: Try, mochitests [Risks and why]: None [String/UUID change made/needed]: None
Attachment #8756010 -
Flags: approval-mozilla-aurora?
Updated•8 years ago
|
status-firefox48:
--- → affected
Comment 5•8 years ago
|
||
bugherder |
https://hg.mozilla.org/mozilla-central/rev/369e41626760
Status: NEW → RESOLVED
Closed: 8 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla49
Comment 6•8 years ago
|
||
Kyle, I am sorry but I don't understand this issue. Could you explain a bit more? Is it a regression? A new feature which needs polish? Thanks
Updated•8 years ago
|
Flags: needinfo?(kyle)
Assignee | ||
Comment 7•8 years ago
|
||
(In reply to Sylvestre Ledru [:sylvestre] from comment #6) > Kyle, I am sorry but I don't understand this issue. Could you explain a bit > more? Is it a regression? A new feature which needs polish? Thanks It's a new feature that's in Aurora now. It allows NPAPI plugins to adjust their rendering based on the current zoom value for the page (the thing that happens when you hit Ctrl-+/-). The way I was sending updates out to plugin libraries worked, but the timing on it was off so the updates didn't happen at the correct time. This patch fixes that.
Flags: needinfo?(kyle)
Comment 8•8 years ago
|
||
Comment on attachment 8756010 [details] MozReview Request: Bug 1269444 - Move Plugin Zoom Value update into SetWindow call; r?bsmedberg OK, thanks for the clear explanation. Taking it in aurora then to polish this new feature
Attachment #8756010 -
Flags: approval-mozilla-aurora? → approval-mozilla-aurora+
Comment 9•8 years ago
|
||
bugherder uplift |
https://hg.mozilla.org/releases/mozilla-aurora/rev/28ba9cceda61
Updated•2 years ago
|
Product: Core → Core Graveyard
You need to log in
before you can comment on or make changes to this bug.
Description
•