Closed Bug 1269444 Opened 4 years ago Closed 4 years ago

NPAPI Browser Zoom value updates are out of order for Adobe Flash

Categories

(Core :: Plug-ins, defect)

defect
Not set

Tracking

()

RESOLVED FIXED
mozilla49
Tracking Status
firefox48 --- fixed
firefox49 --- fixed

People

(Reporter: qdot, Assigned: qdot)

References

Details

Attachments

(1 file)

When receiving browser zoom updates via the new NPNVCSSZoomValue NPAPI variable, updates are sometimes lagging behind, meaning that increasing page zoom sends back the value prior to the zoom.
Summary: NPAPI Browser Zoom value updates are out of order → NPAPI Browser Zoom value updates are out of order for Adobe Flash
Currently, CSS Zoom is updated on calls to ResolutionMayHaveChanged.
However, this happens in between two calls in NPP_SetWindow, one for
widget repaint and then one for resolution updates. Not having CSS Zoom
updated during the first call to NPP_SetWindow would result in
desynchronized window updates in Adobe Flash. Therefore,
ResolutionMayHaveChanged is called on all NPP_SetWindow calls from
nsPluginFrame, meaning the plugin library will always have access to the
correct values via NPP_GetValue/NPP_SetValue.

Review commit: https://reviewboard.mozilla.org/r/54922/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/54922/
Attachment #8756010 - Flags: review?(benjamin)
Comment on attachment 8756010 [details]
MozReview Request: Bug 1269444 - Move Plugin Zoom Value update into SetWindow call; r?bsmedberg

https://reviewboard.mozilla.org/r/54922/#review51768
Attachment #8756010 - Flags: review?(benjamin) → review+
Comment on attachment 8756010 [details]
MozReview Request: Bug 1269444 - Move Plugin Zoom Value update into SetWindow call; r?bsmedberg

Approval Request Comment
[Feature/regressing bug #]: Bug 1171182
[User impact if declined]: CSS Zoom updates for plugins won't work right
[Describe test coverage new/current, TreeHerder]: Try, mochitests
[Risks and why]: None
[String/UUID change made/needed]: None
Attachment #8756010 - Flags: approval-mozilla-aurora?
https://hg.mozilla.org/mozilla-central/rev/369e41626760
Status: NEW → RESOLVED
Closed: 4 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla49
Kyle, I am sorry but I don't understand this issue. Could you explain a bit more? Is it a regression? A new feature which needs polish? Thanks
Flags: needinfo?(kyle)
(In reply to Sylvestre Ledru [:sylvestre] from comment #6)
> Kyle, I am sorry but I don't understand this issue. Could you explain a bit
> more? Is it a regression? A new feature which needs polish? Thanks

It's a new feature that's in Aurora now. It allows NPAPI plugins to adjust their rendering based on the current zoom value for the page (the thing that happens when you hit Ctrl-+/-). The way I was sending updates out to plugin libraries worked, but the timing on it was off so the updates didn't happen at the correct time. This patch fixes that.
Flags: needinfo?(kyle)
Comment on attachment 8756010 [details]
MozReview Request: Bug 1269444 - Move Plugin Zoom Value update into SetWindow call; r?bsmedberg

OK, thanks for the clear explanation. Taking it in aurora then to polish this new feature
Attachment #8756010 - Flags: approval-mozilla-aurora? → approval-mozilla-aurora+
You need to log in before you can comment on or make changes to this bug.