results.xml test failure text should be in child failure attribute

RESOLVED WONTFIX

Status

RESOLVED WONTFIX
2 years ago
2 years ago

People

(Reporter: rwood, Assigned: rwood)

Tracking

Development/Staging

Details

MozReview Requests

Submitter Diff Changes Open Issues Last Updated
Loading...
Error loading review requests:

Attachments

(1 attachment)

(Assignee)

Description

2 years ago
When there is a test failure, the failure text (diff) in coverage/results.xml file is written in the testcase attribute like this:

<?xml version="1.0" encoding="utf-8"?>
<testsuite errors="0" failures="1" name="run-tests" skipped="0" tests="1">
  <testcase name="test-bugzilla.t" time="44.610">
<![CDATA[--- /Users/rwood/version-control-tools/hgext/reviewboard/tests/test-bugzilla.t
+++ /Users/rwood/version-control-tools/hgext/reviewboard/tests/test-bugzilla.t.err
@@ -17,7 +17,7 @@
   $ echo foo1 > foo
   $ hg commit -m 'Bug 1 - Foo 1'
   $ hg push --config reviewboard.autopublish=false
-  zpushing to ssh://$DOCKER_HOSTNAME:$HGPORT6/test-repo
+  pushing to ssh://$DOCKER_HOSTNAME:$HGPORT6/test-repo
   (adding commit id to 1 changesets)
   saved backup bundle to $TESTTMP/client/.hg/strip-backup/24417bc94b2c*-addcommitid.hg (glob)
   searching for changes
]]> </testcase>
</testsuite>

However the test failure diff should be in it's own testcase child failure attribute like this:

<?xml version="1.0" encoding="utf-8"?>
<testsuite errors="0" failures="1" name="run-tests" skipped="0" tests="1">
  <testcase name="test-bugzilla.t" time="44.610">
    <failure message="test failure">
<![CDATA[--- /Users/rwood/version-control-tools/hgext/reviewboard/tests/test-bugzilla.t
+++ /Users/rwood/version-control-tools/hgext/reviewboard/tests/test-bugzilla.t.err
@@ -17,7 +17,7 @@
   $ echo foo1 > foo
   $ hg commit -m 'Bug 1 - Foo 1'
   $ hg push --config reviewboard.autopublish=false
-  zpushing to ssh://$DOCKER_HOSTNAME:$HGPORT6/test-repo
+  pushing to ssh://$DOCKER_HOSTNAME:$HGPORT6/test-repo
   (adding commit id to 1 changesets)
   saved backup bundle to $TESTTMP/client/.hg/strip-backup/24417bc94b2c*-addcommitid.hg (glob)
   searching for changes
]]>    </failure>
  </testcase>
</testsuite>
(Assignee)

Comment 1

2 years ago
Created attachment 8747903 [details]
MozReview Request: Put results.xml failure text in own child attribute (bug 1269458); r=gps

Review commit: https://reviewboard.mozilla.org/r/50069/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/50069/
Attachment #8747903 - Flags: review?(gps)
(Assignee)

Updated

2 years ago
Assignee: nobody → rwood
Status: NEW → ASSIGNED

Comment 2

2 years ago
Comment on attachment 8747903 [details]
MozReview Request: Put results.xml failure text in own child attribute (bug 1269458); r=gps

https://reviewboard.mozilla.org/r/50069/#review46843

run-tests.py comes from upstream Mercurial. We should submit this upstream.

Instructions for that are at https://www.mercurial-scm.org/wiki/ContributingChanges. If you want, I can submit under your name.
Attachment #8747903 - Flags: review?(gps) → review+
(Assignee)

Comment 3

2 years ago
https://reviewboard.mozilla.org/r/50069/#review46843

I suspect I won't be doing many upstream patches, so yes if you have time to submit it I'd appreciate that, thanks!
(Assignee)

Updated

2 years ago
Status: ASSIGNED → RESOLVED
Last Resolved: 2 years ago
Resolution: --- → WONTFIX
You need to log in before you can comment on or make changes to this bug.