Closed
Bug 1269646
Opened 8 years ago
Closed 8 years ago
Assertion failure: mStatus == eInitialized @ mozilla::dom::Console::Method
Categories
(Core :: DOM: Core & HTML, defect)
Core
DOM: Core & HTML
Tracking
()
RESOLVED
FIXED
mozilla49
People
(Reporter: bc, Assigned: baku)
References
()
Details
(Keywords: assertion, regression)
Attachments
(2 files, 2 obsolete files)
4.21 KB,
text/plain
|
Details | |
6.09 KB,
patch
|
smaug
:
review+
ritu
:
approval-mozilla-aurora+
|
Details | Diff | Splinter Review |
1. http://m.babel.com/visit You may need to use a private window since this is otherwise not reproducible after the first load. 2. Assertion failure: mStatus == eInitialized, at /mozilla/builds/nightly/mozilla/dom/base/Console.cpp:1281 #01: mozilla::dom::Console::Method(JSContext*, mozilla::dom::Console::MethodName, nsAString_internal const&, mozilla::dom::Sequence<JS::Value> const&) (/mozilla/builds/nightly/mozilla/dom/base/Console.cpp:1281 (discriminator 1)) Aurora/48, Nightly/49 on Linux, Windows at least according to Bughunter. This has been a fairly common exception on the sites Bughunter tests though not always with this Console::Method frame in the stack.
Assignee | ||
Updated•8 years ago
|
Assignee: nobody → amarchesini
Assignee | ||
Comment 1•8 years ago
|
||
This is interesting. The website does: foo.prototype.onDestroy = function() { console.error("something"); } This 'onDestroy' is executed after inner-window-destroyed.
Attachment #8748082 -
Flags: review?(bugs)
Assignee | ||
Comment 2•8 years ago
|
||
Assignee | ||
Comment 3•8 years ago
|
||
Attachment #8748082 -
Attachment is obsolete: true
Attachment #8748084 -
Attachment is obsolete: true
Attachment #8748082 -
Flags: review?(bugs)
Attachment #8748086 -
Flags: review?(bugs)
Comment 4•8 years ago
|
||
Comment on attachment 8748082 [details] [diff] [review] console.patch Feels error prone to add IsShuttingDown() check for all the callers of Method(). Why not do the check just in Method() and in ProfileMethod()?
Attachment #8748082 -
Attachment is obsolete: false
Updated•8 years ago
|
Attachment #8748086 -
Flags: review?(bugs) → review+
Comment 6•8 years ago
|
||
bugherder |
https://hg.mozilla.org/mozilla-central/rev/cc1443870a87
Status: NEW → RESOLVED
Closed: 8 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla49
Comment 8•8 years ago
|
||
Should we wontfix this for earlier branches than 49? Or is this a good patch for uplift?
Flags: needinfo?(amarchesini)
Assignee | ||
Updated•8 years ago
|
Attachment #8748082 -
Attachment is obsolete: true
Flags: needinfo?(amarchesini)
Assignee | ||
Comment 9•8 years ago
|
||
Comment on attachment 8748086 [details] [diff] [review] console.patch Approval Request Comment [Feature/regressing bug #]: [User impact if declined]: a crash for debug builds [Describe test coverage new/current, TreeHerder]: race condition. [Risks and why]: We didn't consider the shutting down state for any method call. [String/UUID change made/needed]: none
Attachment #8748086 -
Flags: approval-mozilla-aurora?
Comment on attachment 8748086 [details] [diff] [review] console.patch Fix for crash on dbg builds, Aurora48+
Attachment #8748086 -
Flags: approval-mozilla-aurora? → approval-mozilla-aurora+
Comment 11•8 years ago
|
||
bugherder uplift |
https://hg.mozilla.org/releases/mozilla-aurora/rev/acbb89b3299e
Updated•5 years ago
|
Component: DOM → DOM: Core & HTML
You need to log in
before you can comment on or make changes to this bug.
Description
•