|Submitter||Diff||Changes||Open Issues||Last Updated|
|Error loading review requests:|
MozReview Request: mozautomation: only strip MozReview-Commit-ID from commit descriptions (bug 1269649) r?gps
58 bytes, text/x-review-board-request
|Details | Review|
See this review page: https://reviewboard.mozilla.org/r/50135/ Compare the Description (that came with the pushed commit), to what appears in bug 1268379 comment 4. The Bugzilla comment is missing the first line of the 3rd paragraph, the one that starts with "Note:". Either something went wrong in the comment-posting process, or "Note:" is handled in a special way -- which seems a bit more likely than a random line loss, and makes sense since another line starting with "MozReview-Commit-ID:" was also cut. But in any case, I would not expect that line to be removed. If some keywords are used to filter lines, I don't think they should be as simple as 'Note', especially when they appear in the midst of a longer description.
Yeah, mozautomation.commitparser appears to eat any line that starts with a single word (letters and hyphens) followed by a colon: http://hg.mozilla.org/hgcustom/version-control-tools/file/tip/pylib/mozautomation/mozautomation/commitparser.py#l201 There's already a TODO there that the parsing is overly simplified. I'm not sure how many metadata keywords we actually expect; the only one I know of (and the only one mentioned in the function's docstring) is MozReview-Commit-ID. gps, can we have a registry of them to avoid this function being overly greedy?
I think a whitelist of known metadata keywords is fine.
looking over the commit descriptions to mozilla-central and version-control-tools, the only meta tag i found was MozReview-Commit-ID. Review-URL exists in a vct, but that appears to be an experiment at the end of may 2015.
Created attachment 8749054 [details] MozReview Request: mozautomation: only strip MozReview-Commit-ID from commit descriptions (bug 1269649) r?gps Instead of removing anything that may be a meta tag, just remove known tags. Review commit: https://reviewboard.mozilla.org/r/50723/diff/#index_header See other reviews: https://reviewboard.mozilla.org/r/50723/
Comment on attachment 8749054 [details] MozReview Request: mozautomation: only strip MozReview-Commit-ID from commit descriptions (bug 1269649) r?gps https://reviewboard.mozilla.org/r/50723/#review47581