1269656 - [Yahoo] FF46 Partner repack changes

Status: RESOLVED WORKSFORME

(Release Engineering :: Release Requests, defect)

Description

[balduranYahoo]

User Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10_10_5) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/50.0.2661.86 Safari/537.36

Steps to reproduce:

Yahoo had sent one PR for fixing toolbar on FF46, we need to repack new build including that fix.

The related PR is https://github.com/mozilla-partners/yahoo/pull/14

Comment 1

[Mike Kaply [:mkaply]]

Are you sure this PR is correct?

Why are there 6941 files changed to correct this problem?

Comment 2

[balduranYahoo]

Hi Mike,

There're many changes, but it's reasonable.

1. Previously in FF45, the uuid of toolbar is '{635abd67-4fe9-1b23-4f01-e679fa7484c1}'. But it's wrong. We have another uuid of toolbar for bundle browser, which is https://addons.mozilla.org/en-US/developers/addon/yahoo-toolbar1/edit.  Its uuid is '{3F0CE537-A919-4201-9970-00C2820315E4}'

So, you saw these many changes, because we replace the folder name with corrected uuid.

2. The fix for toolbar already was reviewed and approved. Public link is https://addons.mozilla.org/en-US/firefox/addon/yahoo-toolbar/?src=ss

3. You could see my commit history. First remove wrong folder. Second, put fixed version of toolbar into each language folder. Third, bump its version.

Although 6941 files were changed, but it's mainly caused by renaming folder. 

Does it answer your question??

Comment 3

[Mike Kaply [:mkaply]]

Yes. Thank you.

Merged. 

Chris, Can we get this respun? Still looking to put together the email alias.

Thanks.

Comment 4

[balduranYahoo]

Does anything go well??

Comment 5

[balduranYahoo]

Hi Chris,

Could it be done by end of 5/4 ?? I'd like to know when it will be ready for testing?

Comment 6

[Chris Cooper [:coop] (he/him)]

Kicking off the repack now.

Comment 7

[Chris Cooper [:coop] (he/him)]

Repacks for 46.0.1 are in the partner S3 buckets now.

Comment 8

[balduranYahoo]

Attachment: screenshot in clean VM

Comment 9

[balduranYahoo]

Hi Chris,

Could you confirm the repack done??  I download FF 46.0.1-1 from https://fxpartners.mozilla.com/en-US/downloads/ and install it in clean VM. I found that contain old codes of yahoo toolbar 3.2.15.

I attach the screenshot of VM. Please take a look.

Also, could we name next build with 46.0.1-2??  In case same file name can't be override.

Comment 10

[balduranYahoo]

I really need this issue be noticed. Please confirm it.

Comment 11

[Mike Kaply [:mkaply]]

I just installed the Mac en-US build from the partner site and it contains:

3.2.16.20160426042437 version of the toolbar.

Which specific build did you download?

Comment 12

[balduranYahoo]

Hi Mike,

FF 46.0.1-1, win 32, en-US.

Comment 13

[balduranYahoo]

OK, my fail.

I re-start a new VM for testing, and...  yes, it contain 3.2.16.  My bad, really sorry.