Closed
Bug 1269660
Opened 10 years ago
Closed 10 years ago
Fix incorrect usages of SpecialPowers.pushPrefEnv in existing contextual identity browser tests.
Categories
(Core :: DOM: Security, defect)
Core
DOM: Security
Tracking
()
RESOLVED
FIXED
mozilla49
| Tracking | Status | |
|---|---|---|
| firefox49 | --- | fixed |
People
(Reporter: jhao, Assigned: jhao)
References
Details
(Whiteboard: [userContextId][domsecurity-active])
Attachments
(1 file)
|
3.94 KB,
patch
|
baku
:
review+
|
Details | Diff | Splinter Review |
According to baku in https://bugzil.la/1268803#c3, this is the correct way to use SpecialPowers.pushPrefEnv():
add_task(function* setup() {
yield new Promise((resolve) => {
SpecialPowers.pushPrefEnv({"set": [
["privacy.userContext.enabled", true],
]}, resolve);
});
});
We should fix the incorrect usages in contextual identity browser tests.
Updated•10 years ago
|
Status: NEW → ASSIGNED
Whiteboard: [userContextId] → [userContextId][domsecurity-active]
| Assignee | ||
Comment 1•10 years ago
|
||
Hi baku,
Could you review this patch?
Thanks.
Attachment #8749591 -
Flags: review?(amarchesini)
Updated•10 years ago
|
Attachment #8749591 -
Flags: review?(amarchesini) → review+
| Assignee | ||
Comment 2•10 years ago
|
||
| Assignee | ||
Updated•10 years ago
|
Keywords: checkin-needed
Keywords: checkin-needed
Comment 4•10 years ago
|
||
| bugherder | ||
Status: ASSIGNED → RESOLVED
Closed: 10 years ago
status-firefox49:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla49
You need to log in
before you can comment on or make changes to this bug.
Description
•