Closed Bug 1269660 Opened 4 years ago Closed 4 years ago

Fix incorrect usages of SpecialPowers.pushPrefEnv in existing contextual identity browser tests.

Categories

(Core :: DOM: Security, defect)

defect
Not set

Tracking

()

RESOLVED FIXED
mozilla49
Tracking Status
firefox49 --- fixed

People

(Reporter: jhao, Assigned: jhao)

References

Details

(Whiteboard: [userContextId][domsecurity-active])

Attachments

(1 file)

According to baku in https://bugzil.la/1268803#c3, this is the correct way to use SpecialPowers.pushPrefEnv():

add_task(function* setup() {
  yield new Promise((resolve) => {
    SpecialPowers.pushPrefEnv({"set": [
      ["privacy.userContext.enabled", true],
    ]}, resolve);
  });
});

We should fix the incorrect usages in contextual identity browser tests.
Status: NEW → ASSIGNED
Whiteboard: [userContextId] → [userContextId][domsecurity-active]
Hi baku,
Could you review this patch?
Thanks.
Attachment #8749591 - Flags: review?(amarchesini)
Attachment #8749591 - Flags: review?(amarchesini) → review+
Keywords: checkin-needed
https://hg.mozilla.org/mozilla-central/rev/e5e098755b52
Status: ASSIGNED → RESOLVED
Closed: 4 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla49
You need to log in before you can comment on or make changes to this bug.