Closed Bug 1269661 Opened 8 years ago Closed 8 years ago

Checkstyle violations in history panel code

Categories

(Firefox for Android Graveyard :: General, defect)

All
Android
defect
Not set
normal

Tracking

(firefox48 fixed, firefox49 fixed)

RESOLVED FIXED
Firefox 49
Tracking Status
firefox48 --- fixed
firefox49 --- fixed

People

(Reporter: sebastian, Assigned: liuche)

References

Details

Attachments

(1 file)

Running checkstyle locally shows me errors in the following files:

* mobile/android/base/java/org/mozilla/gecko/home/ClientsAdapter.java
  '{' is not preceded with whitespace. line 99
* mobile/android/base/java/org/mozilla/gecko/home/CombinedHistoryAdapter.java
  '{' is not preceded with whitespace. line 135
* mobile/android/base/java/org/mozilla/gecko/home/CombinedHistoryPanel.java
  '?' is not preceded with whitespace. line 374
Flags: needinfo?(liuche)
Blocks: 1263471
Flags: needinfo?(michael.l.comella)
Flags: needinfo?(michael.l.comella)
Assignee: nobody → liuche
Flags: needinfo?(liuche)
Comment on attachment 8748328 [details]
MozReview Request: Bug 1269661 - Checkstyle violations in history panel code. r=mcomella

https://reviewboard.mozilla.org/r/50221/#review47099

fo sho. Thanks for keeping it squeaky clean!
Attachment #8748328 - Flags: review?(michael.l.comella) → review+
https://hg.mozilla.org/mozilla-central/rev/932e2fda5e33
Status: NEW → RESOLVED
Closed: 8 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 49
sebastian, lizzard this needs also uplifted to aurora to fix the checkstyle warnings, so need approval for that :)
Flags: needinfo?(s.kaspari)
Flags: needinfo?(lhenry)
Flags: needinfo?(lhenry)
Comment on attachment 8748328 [details]
MozReview Request: Bug 1269661 - Checkstyle violations in history panel code. r=mcomella

Let's uplift this to aurora.
Attachment #8748328 - Flags: approval-mozilla-aurora+
Flags: needinfo?(s.kaspari)
Product: Firefox for Android → Firefox for Android Graveyard
You need to log in before you can comment on or make changes to this bug.