Closed
Bug 1269661
Opened 8 years ago
Closed 8 years ago
Checkstyle violations in history panel code
Categories
(Firefox for Android Graveyard :: General, defect)
Tracking
(firefox48 fixed, firefox49 fixed)
RESOLVED
FIXED
Firefox 49
People
(Reporter: sebastian, Assigned: liuche)
References
Details
Attachments
(1 file)
58 bytes,
text/x-review-board-request
|
mcomella
:
review+
lizzard
:
approval-mozilla-aurora+
|
Details |
Running checkstyle locally shows me errors in the following files: * mobile/android/base/java/org/mozilla/gecko/home/ClientsAdapter.java '{' is not preceded with whitespace. line 99 * mobile/android/base/java/org/mozilla/gecko/home/CombinedHistoryAdapter.java '{' is not preceded with whitespace. line 135 * mobile/android/base/java/org/mozilla/gecko/home/CombinedHistoryPanel.java '?' is not preceded with whitespace. line 374
Flags: needinfo?(liuche)
Reporter | ||
Updated•8 years ago
|
Flags: needinfo?(michael.l.comella)
Assignee | ||
Comment 2•8 years ago
|
||
Review commit: https://reviewboard.mozilla.org/r/50221/diff/#index_header See other reviews: https://reviewboard.mozilla.org/r/50221/
Attachment #8748328 -
Flags: review?(michael.l.comella)
Assignee | ||
Updated•8 years ago
|
Assignee: nobody → liuche
Flags: needinfo?(liuche)
Comment on attachment 8748328 [details] MozReview Request: Bug 1269661 - Checkstyle violations in history panel code. r=mcomella https://reviewboard.mozilla.org/r/50221/#review47099 fo sho. Thanks for keeping it squeaky clean!
Attachment #8748328 -
Flags: review?(michael.l.comella) → review+
https://hg.mozilla.org/integration/fx-team/rev/932e2fda5e33bd2d80ac53df43ee59880780ad7c Bug 1269661 - Checkstyle violations in history panel code. r=mcomella
Comment 5•8 years ago
|
||
bugherder |
https://hg.mozilla.org/mozilla-central/rev/932e2fda5e33
Status: NEW → RESOLVED
Closed: 8 years ago
status-firefox49:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 49
Comment 6•8 years ago
|
||
sebastian, lizzard this needs also uplifted to aurora to fix the checkstyle warnings, so need approval for that :)
Flags: needinfo?(s.kaspari)
Flags: needinfo?(lhenry)
Updated•8 years ago
|
status-firefox48:
--- → affected
Flags: needinfo?(lhenry)
Comment 7•8 years ago
|
||
Comment on attachment 8748328 [details] MozReview Request: Bug 1269661 - Checkstyle violations in history panel code. r=mcomella Let's uplift this to aurora.
Attachment #8748328 -
Flags: approval-mozilla-aurora+
Comment 8•8 years ago
|
||
bugherder uplift |
https://hg.mozilla.org/releases/mozilla-aurora/rev/d15a9f7b103f
Reporter | ||
Updated•8 years ago
|
Flags: needinfo?(s.kaspari)
Updated•3 years ago
|
Product: Firefox for Android → Firefox for Android Graveyard
You need to log in
before you can comment on or make changes to this bug.
Description
•