1269682 - Crash in java.lang.IllegalStateException: Already registered Prompt:ShowTop at org.mozilla.gecko.EventDispatcher.registerListener(EventDispatcher.java)

Status: VERIFIED FIXED

(Firefox for Android Graveyard :: Profile Handling, defect)

Description

[Sorina Florean [:sflorean]]

This bug was filed from the Socorro interface and is 
report bp-6a6834a6-1323-4209-bfed-296912160429.
=============================================================

Environment: 
Device: Nexus 5 (Android 6.0.1);
Build: Nightly 49.0a1 (2016-05-02);

Steps to reproduce:
1. Launch Firefox; 
2. Go to Tools-> New Guest Session;
3. Close Firefox.
4. Launch Firefox. 

Expected result:
Firefox opens and about:home is displayed.

Actual result:
Firefox crashes.

Stack Trace:
java.lang.IllegalStateException: Already registered Prompt:ShowTop
	at org.mozilla.gecko.EventDispatcher.registerListener(EventDispatcher.java:84)
	at org.mozilla.gecko.EventDispatcher.registerGeckoThreadListener(EventDispatcher.java:151)
	at org.mozilla.gecko.BrowserApp.onPause(BrowserApp.java:1101)
	at android.app.Activity.performPause(Activity.java:6348)
	at android.app.Instrumentation.callActivityOnPause(Instrumentation.java:1311)
	at android.app.ActivityThread.performPauseActivity(ActivityThread.java:3367)
	at android.app.ActivityThread.performPauseActivity(ActivityThread.java:3340)
	at android.app.ActivityThread.handlePauseActivity(ActivityThread.java:3315)
	at android.app.ActivityThread.-wrap13(ActivityThread.java)
	at android.app.ActivityThread$H.handleMessage(ActivityThread.java:1362)
	at android.os.Handler.dispatchMessage(Handler.java:102)
	at android.os.Looper.loop(Looper.java:148)
	at android.app.ActivityThread.main(ActivityThread.java:5417)
	at java.lang.reflect.Method.invoke(Native Method)
	at com.android.internal.os.ZygoteInit$MethodAndArgsCaller.run(ZygoteInit.java:726)
	at com.android.internal.os.ZygoteInit.main(ZygoteInit.java:616)

Comment 2

[Kevin Brosnan [Ex-Mozilla]]

[Tracking Requested - why for this release]: regression

Comment 3

[Sorina Florean [:sflorean]]

Regression window:
Last good build: 2016-04-05
First bad build: 2016-04-06
pushlog:
https://hg.mozilla.org/mozilla-central/pushloghtml?fromchange=d9f50aa0a1aaf90499b85c31e0f329b762e80fdd&tochange=68c0b7d6f16ce5bb023e08050102b5f2fe4aacd8

Comment 4

[Kevin Brosnan [Ex-Mozilla]]

Likely Jim's Gecko Service stuff.

Comment 5

[(inactive) Jim Chen [:jchen] [:darchons]]

Attachment: Guard against onPause being called without onResume (v1)

When we try to restart Fennec immediately after launching Fennec, it's
possible for onPause to be called without a corresponding onResume being
called first. This patch guards against registering events twice due to
this quirk.

Comment 6

[(inactive) Jim Chen [:jchen] [:darchons]]

Attachment: Don't try to switch to guest profile (v1)

BrowserApp has a snippet that tries to restart in guest profile if we're
supposed to be in it, but are currently not. This is vestigial code from
lock screen widget support, and should not be needed anymore.

Comment 7

[(inactive) Jim Chen [:jchen] [:darchons]]

Attachment: Always detect guest mode first (v1)

Always check for guest mode even if we don't have arguments, because
we can still be in guest mode even if we don't have arguments.

Comment 8

[Marcia Knous [:marcia]]

Tracking for 48/49.

Comment 9

[Pulsebot]

https://hg.mozilla.org/integration/mozilla-inbound/rev/ba36438e7258
https://hg.mozilla.org/integration/mozilla-inbound/rev/710f4c21891e
https://hg.mozilla.org/integration/mozilla-inbound/rev/fe2780a12fd3

Comment 10

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/ba36438e7258
https://hg.mozilla.org/mozilla-central/rev/710f4c21891e
https://hg.mozilla.org/mozilla-central/rev/fe2780a12fd3

Comment 11

[(inactive) Jim Chen [:jchen] [:darchons]]

Comment on attachment 8749670 [details] [diff] [review]
Guard against onPause being called without onResume (v1)

Request for all patches.

Approval Request Comment
[Feature/regressing bug #]: Bug 1258554
[User impact if declined]: Crashes when entering guest mode
[Describe test coverage new/current, TreeHerder]: Local, m-c
[Risks and why]: Small; patches shouldn't really affect behavior besides fixing crash
[String/UUID change made/needed]: None

Comment 12

[Sorina Florean [:sflorean]]

Verified as fixed in build 49.0a1 2016-05-11;
Device: Nexus 5 (Android 6.0.1) and Asus Transformer Pad (Android 4.2.1).

Comment 13

[Gerry Chang [:gchang]]

Comment on attachment 8749670 [details] [diff] [review]
Guard against onPause being called without onResume (v1)

This patch fixes the crashes when entering guest mode and is verified. Take it in aurora.

Comment 14

[Gerry Chang [:gchang]]

Based on comment #13, take all patches in aurora.

Comment 15

[Carsten Book [:Tomcat]]

has problems uplifting 

grafting 344048:ba36438e7258 "Bug 1269682 - Guard against onPause being called without onResume; r=ahunt"
merging mobile/android/base/java/org/mozilla/gecko/BrowserApp.java
warning: conflicts while merging mobile/android/base/java/org/mozilla/gecko/BrowserApp.java! (edit, then use 'hg resolve --mark')
abort: unresolved conflicts, can't continue
(use 'hg resolve' and 'hg graft --continue')
Tomcats-MacBook-Pro-2:mozilla-central Tomcat$

Comment 16

[(inactive) Jim Chen [:jchen] [:darchons]]

Attachment: Combined patch for Aurora

Comment 17

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/releases/mozilla-aurora/rev/a2c46d6880e2

Comment 18

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

This caused a permafail on aurora: https://treeherder.mozilla.org/logviewer.html#?job_id=2649836&repo=mozilla-aurora

Backed out in https://hg.mozilla.org/releases/mozilla-aurora/rev/9c28c3b843d9

Comment 19

[(inactive) Jim Chen [:jchen] [:darchons]]

Attachment: Combined patch for Aurora (v2)

Oops! Here's a new patch.

Comment 20

[Carsten Book [:Tomcat]]

  https://hg.mozilla.org/releases/mozilla-aurora/rev/12f53b845cb9

Comment 21

[Sorina Florean [:sflorean]]

Verified as fixed in build 48.0a2 2016-05-26;
Device: Asus ZenPad 8 (Android 5.0.2) and Nexus 5 (Android 6.0.1).