1269763 - Convert instances of toolbox.frame.contentWindow to toolbox.win

Status: RESOLVED FIXED

(DevTools :: Framework, enhancement, P1)

Description

[Brian Grinstead [:bgrins]]

Now that a toolbox.win getter has been added (bug 1269497), we should be able to convert instances of toolbox.frame.contentWindow to use that: https://bugzilla.mozilla.org/show_bug.cgi?id=1269497#c5

Comment 1

[Brian Grinstead [:bgrins]]

May as well block Bug 1259121 since it's follow up work

Comment 2

[Brian Grinstead [:bgrins]]

Attachment: MozReview Request: Bug 1269763 - Convert instances of toolbox.frame.contentWindow to toolbox.win;r=jdescottes

Review commit: https://reviewboard.mozilla.org/r/50177/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/50177/

Comment 3

[Brian Grinstead [:bgrins]]

Let's see how it turns up: https://treeherder.mozilla.org/#/jobs?repo=try&revision=d4836ae7dec2

Comment 4

[Brian Grinstead [:bgrins]]

Comment on attachment 8748187 [details]
MozReview Request: Bug 1269763 - Convert instances of toolbox.frame.contentWindow to toolbox.win;r=jdescottes

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/50177/diff/1-2/

Comment 5

[Julian Descottes [:jdescottes]]

Comment on attachment 8748187 [details]
MozReview Request: Bug 1269763 - Convert instances of toolbox.frame.contentWindow to toolbox.win;r=jdescottes

https://reviewboard.mozilla.org/r/50177/#review47031

Nice, thanks!

Comment 6

[Pulsebot]

https://hg.mozilla.org/integration/fx-team/rev/897255b50fc9

Comment 7

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/897255b50fc9