1269775 - OdinMonkey: MIPS: Implement int32/int64 rotations

Status: RESOLVED FIXED

(Core :: JavaScript Engine: JIT, defect)

Description

[hev [:hev]]

* MacroAssembler::rotateLeft(Imm32 count, Register input, Register dest)
* MacroAssembler::rotateLeft(Register count, Register input, Register dest)
* MacroAssembler::rotateRight(Imm32 count, Register input, Register dest)
* MacroAssembler::rotateRight(Register count, Register input, Register dest)
* CodeGeneratorMIPS64::visitRotate64(LRotate64* lir)

Comment 1

[hev [:hev]]

Attachment: 0001-Bug-1269775-OdinMonkey-MIPS-Implement-int32-int64-ro.patch

Comment 2

[Benjamin Bouvier [:bbouvier] (inactive)]

Comment on attachment 8748429 [details] [diff] [review]
0001-Bug-1269775-OdinMonkey-MIPS-Implement-int32-int64-ro.patch

Review of attachment 8748429 [details] [diff] [review]:
-----------------------------------------------------------------

Thank you for the patch. Int32 rotations should work well. But int64 rotations are missing some code, I think. Feel free to split the patches (one for i32 r=me, the other for i64 and ask me for review on this one).

::: js/src/jit/mips64/CodeGenerator-mips64.cpp
@@ +304,5 @@
>  }
>  
>  void
> +CodeGeneratorMIPS64::visitRotate64(LRotate64* lir)
> +{

It seems lowerForShiftInt64 is not implemented for mips64 / mips-shared, so this is technically dead code.

@@ +306,5 @@
>  void
> +CodeGeneratorMIPS64::visitRotate64(LRotate64* lir)
> +{
> +    MRotate* mir = lir->mir();
> +    Register input = ToRegister(lir->input());

Is there a constraint that input == output register? If MIPS is more well-behaved than x86, like ARM, I wouldn't think so.

Comment 3

[hev [:hev]]

Attachment: 0001-Bug-1269775-OdinMonkey-MIPS-Implement-int32-rotation.patch

Comment 4

[Benjamin Bouvier [:bbouvier] (inactive)]

Comment on attachment 8748958 [details] [diff] [review]
0001-Bug-1269775-OdinMonkey-MIPS-Implement-int32-rotation.patch

Review of attachment 8748958 [details] [diff] [review]:
-----------------------------------------------------------------

Looks good, thanks!

Comment 5

[Pulsebot]

https://hg.mozilla.org/integration/mozilla-inbound/rev/51a6a9475189

Comment 6

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/51a6a9475189